Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional.
Date: Wed, 25 Jan 2017 10:23:10 +1300	[thread overview]
Message-ID: <20170125102310.5f050cf1@free-electrons.com> (raw)
In-Reply-To: <20170124203139.15919-3-aduskett@codeblue.com>

Hello,

On Tue, 24 Jan 2017 15:31:32 -0500, Adam Duskett wrote:
> Currently janus-gateway is built by default with the audio bridge plugin.
> This causes a example config file to be placed on the target filing system
> that the user may not need or want.

I'm not sure to understand this config file story. Why does it matter?
Are these plugin options only installing a config file, or also a
plugin library or something like this?

What is the filesystem size contribution of each plugin? Is it
significant enough to justify having all those additional plugin
options?

> +config BR2_PACKAGE_JANUS_PLUGIN_AUDIO_BRIDGE
> +	bool "janus audio bridge plugin"
> +	default n

Remove "janus" from the prompt: those options are already indented
under the main janus option, so there is no point in repeating that.

And remove the "default n", as it's the default.

I'm just wondering if we shouldn't use "default y" instead, in order to
preserve backward compatibility. But that kind of violates the general
Buildroot rule of "let's build a minimal thing by default". Since I'm
not too strict on backward compatibility, I'd say leave them disabled
by default (but others might disagree).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-01-24 21:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 20:31 [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 02/10] janus-gateway: Make sofia-sip a optional dependency Adam Duskett
2017-01-24 21:15   ` Thomas Petazzoni
2017-01-24 20:31 ` [Buildroot] [V2 03/10] janus-gateway: Make audio bridge plugin optional Adam Duskett
2017-01-24 21:23   ` Thomas Petazzoni [this message]
2017-01-24 20:31 ` [Buildroot] [V2 04/10] janus-gateway: Make echo test " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 05/10] janus-gateway: Make recordplay " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 06/10] janus-gateway: Make streaming " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 07/10] janus-gateway: Make text room " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 08/10] janus-gateway: Make video call " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 09/10] janus-gateway: Make video room " Adam Duskett
2017-01-24 20:31 ` [Buildroot] [V2 10/10] janus-gateway: Make voicemail " Adam Duskett
2017-01-24 23:57 ` [Buildroot] [V2 01/10] janus-gateway: bump to version v0.2.1 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125102310.5f050cf1@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox