Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Duskett <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V3 10/10] janus-gateway: Make voicemail plugin optional.
Date: Wed, 25 Jan 2017 08:42:45 -0500	[thread overview]
Message-ID: <20170125134245.12920-10-aduskett@codeblue.com> (raw)
In-Reply-To: <20170125134245.12920-1-aduskett@codeblue.com>

Currently janus-gateway's voicemail plugin is only built if
libogg is selected, and even then there is no way to disable the plugin from
being built. This causes a example config file to be placed on 
the target filing system that the user may not need or want, creates a 33K .so
file on the target directory, and janus will also generate a warning when
ran if the plugin does not have a matching configuration file setup by
the user, as it will not use the example config file by default.

This patch makes the voicemail plugin optional, removes the check for libogg,
adds libogg as a dependency to the voicemail plugin, and selects the libogg
package automatically when the user selects the plugin.

Signed-off-by: Adam Duskett <aduskett@codeblue.com>
---
v2 -> v3:
  - Removed 'PLUGIN' from the name; as this is implied.
  - Removed 'default n' from the config file, as this is the default.
  - Selecting the voicemail plugin now adds libogg to the dependencies in the
    make file and selects the libogg package in the config file.
  - remove unecessary check for libogg in the make file as the package is now
    selected by default if the user chooses to enable the voicemail plugin.
v1 -> v2:
  - No changes.
  
 package/janus-gateway/Config.in        |  4 ++++
 package/janus-gateway/janus-gateway.mk | 14 +++++++-------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 3bf533e..2cb771f 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -45,6 +45,10 @@ config BR2_PACKAGE_JANUS_VIDEO_CALL
 config BR2_PACKAGE_JANUS_VIDEO_ROOM
 	bool "video room"
 
+config BR2_PACKAGE_JANUS_VOICE_MAIL
+	select BR2_PACKAGE_LIBOGG
+	bool "voice mail"
+
 endif
 
 comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index b9a36a0..212fa47 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -76,6 +76,13 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-plugin-videoroom
 endif
 
+ifeq ($(BR2_PACKAGE_JANUS_VOICE_MAIL),y)
+JANUS_GATEWAY_DEPENDENCIES += libogg
+JANUS_GATEWAY_CONF_OPTS += --enable-plugin-voicemail
+else
+JANUS_GATEWAY_CONF_OPTS += --disable-plugin-voicemail
+endif
+
 ifeq ($(BR2_PACKAGE_LIBWEBSOCKETS),y)
 JANUS_GATEWAY_DEPENDENCIES += libwebsockets
 JANUS_GATEWAY_CONF_OPTS += --enable-websockets
@@ -83,13 +90,6 @@ else
 JANUS_GATEWAY_CONF_OPTS += --disable-websockets
 endif
 
-ifeq ($(BR2_PACKAGE_LIBOGG),y)
-JANUS_GATEWAY_DEPENDENCIES += libogg
-JANUS_GATEWAY_CONF_OPTS += --enable-plugin-voicemail
-else
-JANUS_GATEWAY_CONF_OPTS += --disable-plugin-voicemail
-endif
-
 # Parallel build broken
 JANUS_GATEWAY_MAKE = $(MAKE1)
 
-- 
2.9.3

  parent reply	other threads:[~2017-01-25 13:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 13:42 [Buildroot] [V3 01/10] janus-gateway: remove unessasary dependencies Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 02/10] janus-gateway: Make sofia-sip a optional dependency Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 03/10] janus-gateway: Make audio bridge plugin optional Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 04/10] janus-gateway: Make echo test " Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 05/10] janus-gateway: Make recordplay " Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 06/10] janus-gateway: Make streaming " Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 07/10] janus-gateway: Make text room " Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 08/10] janus-gateway: Make video call " Adam Duskett
2017-01-25 13:42 ` [Buildroot] [V3 09/10] janus-gateway: Make video room " Adam Duskett
2017-01-25 13:42 ` Adam Duskett [this message]
2017-01-28  8:46 ` [Buildroot] [V3 01/10] janus-gateway: remove unessasary dependencies Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125134245.12920-10-aduskett@codeblue.com \
    --to=aduskett@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox