From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 1 Feb 2017 22:11:18 +0100 Subject: [Buildroot] [PATCH 1/1] core infra: make sure apply-patches is called with correct tar In-Reply-To: <20170201112708.17709-1-patrickdepinguin@gmail.com> References: <20170201112708.17709-1-patrickdepinguin@gmail.com> Message-ID: <20170201221118.6cda53d9@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Wed, 1 Feb 2017 12:27:08 +0100, Thomas De Schampheleire wrote: > From: Thomas De Schampheleire > > Buildroot has a mechanism to detect a too-old or missing tar program on the > host machine, and builds a custom host-tar if needed. An example situation > is a RHEL5 host machine, where tar is knowingly too old. > > The apply-patches script also employs tar, in case the patches come as an > archive. However, tar is called as 'tar' without any absolute path, and the > environment does not point in any way to the possibly custom tar. As a > result, the too-old-tar is called. A particular problem is the flag '-a' > which is missing on e.g. RHEL5. > > Previously, this problem went unnoticed: tar would fail, but apply-patches > did not notice it, and the overall return code of the script was 'success'. > However, commit d5ae67b4 added 'set -e' to the script, causing any error to > halt execution of the script with an error. > > Fix the problem by adding the Buildroot-built host tools to the PATH when > calling apply-patches. > > Signed-off-by: Thomas De Schampheleire > --- > package/Makefile.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com