From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] imagemagick: fix build of png support when jpeg support is disabled
Date: Mon, 6 Feb 2017 19:20:54 +0100 [thread overview]
Message-ID: <20170206192054.06cef3ed@free-electrons.com> (raw)
In-Reply-To: <20170206170255.19487-1-peter@korsgaard.com>
Hello,
On Mon, 6 Feb 2017 18:02:55 +0100, Peter Korsgaard wrote:
> Fixes:
> http://autobuild.buildroot.net/results/d20/d20eecec8e7b947759185f77a6c8e610dd7393f3/
> http://autobuild.buildroot.net/results/ee1/ee15efa8ae3f95244980810155ff7ba9f885a59d/
> http://autobuild.buildroot.net/results/aa8/aa80f2fd4c7dd884ea8a1b55ad15a40c7bf40501/
> http://autobuild.buildroot.net/results/9aa/9aaa044f78115d7f599ea09669c0d6bface5633e/
>
> This combination is broken since 7.0.4-6.
>
> Since commit a9e228f8ac26 (Implemented a private PNG caNv (canvas) chunk),
> PNGsLong gets called unconditionally, but it is only defined if JPEG
> support is enabled (which defines JNG_SUPPORTED), breaking the build:
>
> MagickCore/.libs/libMagickCore-7.Q16HDRI.a(MagickCore_libMagickCore_7_Q16HDRI_la-png.o): In function `WriteOnePNGImage':
> png.c:(.text+0x748d): undefined reference to `PNGsLong'
> png.c:(.text+0x74b7): undefined reference to `PNGsLong'
>
> Fix it by adding a patch unconditionally defining the helper function.
>
> Patch submitted upstream.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> Changes since v1:
> - Add link to upstream pull request
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-02-06 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 17:02 [Buildroot] [PATCHv2] imagemagick: fix build of png support when jpeg support is disabled Peter Korsgaard
2017-02-06 18:20 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206192054.06cef3ed@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox