[Buildroot] [PATCH v6 0/9] bump/choice for qt 5.8.0

[Peter Seiderer <ps.report@gmx.net>]

Hello Arnout,

On Mon, 6 Feb 2017 21:54:15 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:

> 
> 
> On 06-02-17 21:36, Peter Seiderer wrote:
> > On Mon, 6 Feb 2017 21:24:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:
> > 
> >>
> >>
> >> On 06-02-17 18:44, Andreas Naumann wrote:
> >>> Hi,
> >>>
> >>> first of all, thanks everybody for taking over and pushing this further. My
> >>> finding on this below..
> >>>
> >>> Am 06.02.2017 um 16:40 schrieb Thomas Petazzoni:
> >>>> Hello,
> >>>>
> >>>> On Tue, 31 Jan 2017 08:59:02 +0100, Zoltan Gyarmati wrote:
> >>>>
> >>>>> The Qt 5.8 config (and pyqt5) was tested on Raspberry Pi.
> >>>>
> >>>> As Arnout said we are trying to apply this patch series (or actually a
> >>>> subset of it). We have already fixed the comments that people have
> >>>> raised, and you can see the result at:
> >>>>
> >>>>   http://git.free-electrons.com/users/thomas-petazzoni/buildroot/log/?h=qt5-bump
> >>>>
> >>>> Unfortunately, this fails to build with the following defconfig:
> >>>>
> >>>> BR2_arm=y
> >>>> BR2_cortex_a8=y
> >>>> BR2_TOOLCHAIN_EXTERNAL=y
> >>>> BR2_PACKAGE_QT5=y
> >>>> BR2_PACKAGE_QT5BASE_LICENSE_APPROVED=y
> >>>> BR2_PACKAGE_QT5DECLARATIVE=y
> >>>> BR2_PACKAGE_QT5IMAGEFORMATS=y
> >>>> BR2_PACKAGE_QT5LOCATION=y
> >>>> BR2_PACKAGE_QT5MULTIMEDIA=y
> >>>> BR2_PACKAGE_QT5SENSORS=y
> >>>> BR2_PACKAGE_QT5SERIALBUS=y
> >>>> BR2_PACKAGE_QT5SVG=y
> >>>> BR2_PACKAGE_QT5TOOLS=y
> >>>> BR2_PACKAGE_QT5TOOLS_PIXELTOOL=y
> >>>> BR2_PACKAGE_QT5TOOLS_QTDIAG=y
> >>>> BR2_PACKAGE_QT5TOOLS_QTPATHS=y
> >>>> BR2_PACKAGE_QT5TOOLS_QTPLUGININFO=y
> >>>> BR2_PACKAGE_QT5WEBCHANNEL=y
> >>>> BR2_PACKAGE_QT5ENGINIO=y
> >>>>
> >>>> With the following error message during the qt5base build:
> >>>>
> >>>>   Project ERROR: Library 'libpng' is not defined.
> >>>>
> >>>> Could you take our branch, and see why there is this build failure ?
> >>>
> >>> I have tried your branch and defconfig and see the same failure. Unfortunately I
> >>> have no idea why it happens, I have never observed that problem.
> >>>
> >>> There are reports about these kind of problem, but without a hint for the real
> >>> reason.
> >>> https://bugreports.qt.io/browse/QTBUG-57148
> >>
> >>  That's something else, it happens while building the bundled freetype which we
> >> don't do.
> >>
> >>> https://bugreports.qt.io/browse/QTBUG-57794
> >>
> >>  That one looks like the same issue.
> >>
> >>>
> >>> After fiddling a little, I can get over it by selecting
> >>> BR2_PACKAGE_QT5BASE_FONTCONFIG. Unfortunately I run out of time debugging
> >>> further for now.
> >>
> >>  Since it would be really nice to have Qt5.8 in 2017.02, I wouldn't mind working
> >> around it with
> >>
> >> 	# Not clear why this is needed, the build fails without it
> >> 	select BR2_PACKAGE_QT5BASE_FONTCONFIG if BR2_PACKAGE_QT5_VERSION_LATEST
> >>
> >> to BR2_PACKAGE_QT5BASE_PNG. Thomas and I looked at it as well for a little while
> >> and couldn't come up with an explanation.
> >>
> >>  It would be good however to report our findings in QTBUG-57794.
> > 
> > QTBUG-57794 points to QTBUG-58038 [1] with fix attached (see [2] and [3]),
> > may be worth a try?
> 
>  How did I miss that reference!
> 

And the patche worked for me with the given defconfig...

>  But that is not the correct fix for us. That fix will make sure that the
> bundled freetype is built when the system libpng is selected. But we of course
> want the system freetype, not the bundled one. QTBUG-58038 will indeed fix the
> build, but it's not what we want. We need to pass -system-freetype and select
> BR2_PACKAGE_FREETYPE.

I think this would be another improvement fix/patch (can be done on top of the
patchset)?

System freetype is not used at the moment (not for 5.6 and 5.8)...

Regards,
Peter


> 
>  To be checked:
> 
> - is this also the case for 5.6?
> 
> - under which circumstances does freetype have to be selected?
> 
>  Regards,
>  Arnout
> 
> > 
> > Regards,
> > Peter
> > 
> > 
> > [1] https://bugreports.qt.io/browse/QTBUG-58038
> > [2] https://codereview.qt-project.org/181808
> > [3] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=4dcfd90e4fd7d4c49138038dbbcbda8794a9fbff
> > 
> > 
> >>
> >>  Regards,
> >>  Arnout
> >>
> > 
>