From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] logrotate: enable selinux support.
Date: Tue, 7 Feb 2017 17:43:42 +0100 [thread overview]
Message-ID: <20170207174342.3957512b@free-electrons.com> (raw)
In-Reply-To: <20170207140411.2656-2-Adamduskett@outlook.com>
Hello,
On Tue, 7 Feb 2017 09:04:11 -0500, Adam Duskett wrote:
> Selinux is currently disabled staticly in logrotate. This patch
> fixes this by checking for libselinux and adding it as a dependecy
> if it has been selected. The configure script is set to check for
> libselinux by default, so I only set --without-selinux implicitly
> if libselinux hasn't been selected, otherwise it's left alone.
No, we really want --with-selinux. If you don't pass --with-selinux,
then the default beaviour of this configure is to "check", which means
that if it finds SELinux support, it enables it, otherwise it moves on
with SELinux disabled.
But in Buildroot, if we enable SELinux support, we really want it. We
don't want package to silently ignore it if there's some kind of error.
Which is why for all optional dependencies, we always explicitly
enable/disable it.
I've fixed that up and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-07 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 14:04 [Buildroot] [PATCH 1/2] logrotate: bump to version 3.11.0 Adam Duskett
2017-02-07 14:04 ` [Buildroot] [PATCH 2/2] logrotate: enable selinux support Adam Duskett
2017-02-07 16:43 ` Thomas Petazzoni [this message]
2017-02-07 16:42 ` [Buildroot] [PATCH 1/2] logrotate: bump to version 3.11.0 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207174342.3957512b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox