From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3] package/ccache: do not force colored diagnostics
Date: Sun, 12 Feb 2017 14:34:32 +0100 [thread overview]
Message-ID: <20170212143432.4aa112f0@free-electrons.com> (raw)
In-Reply-To: <1486906227-5682-1-git-send-email-yann.morin.1998@free.fr>
Hello,
On Sun, 12 Feb 2017 14:30:27 +0100, Yann E. MORIN wrote:
> +# Further patch ccache if either the host or target compilers is
compilers -> compiler (I believe, though I'm not an expert in english
grammar)
> +# too old to support colored output diagnostics.
> +ifneq ($(BR2_HOST_GCC_AT_LEAST_4_9)$(BR2_TOOLCHAIN_GCC_AT_LEAST_4_9),yy)
> +define CCACHE_NO_GCC_COLORS
> + sed -i '/if (getenv("GCC_COLORS")/,+3d' $(@D)/ccache.c
Using $(SED) not possible here?
> +endef
> +
> +#HOST_CCACHE_POST_PATCH_HOOKS += CCACHE_NO_GCC_COLORS
Line commented? :-)
Other than that, looks good to me.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-12 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 13:30 [Buildroot] [PATCHv3] package/ccache: do not force colored diagnostics Yann E. MORIN
2017-02-12 13:34 ` Thomas Petazzoni [this message]
2017-02-12 13:37 ` Yann E. MORIN
2017-02-12 13:34 ` Baruch Siach
2017-02-12 21:39 ` Arnout Vandecappelle
2017-02-13 16:09 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170212143432.4aa112f0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox