Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5] gqrx: new package
Date: Mon, 13 Feb 2017 13:35:07 +0100	[thread overview]
Message-ID: <20170213133507.67a46075@free-electrons.com> (raw)
In-Reply-To: <20170213093839.38b994c9@x230.trabucayre.com>

Hello,

On Mon, 13 Feb 2017 09:38:39 +0100, gwenhael.goavec wrote:

> I'm agree, maybe portaudio by default because gnuradio users seems to
> use it preferentially.

OK. portaudio only depends on thread support, and gnuradio already
needs thread support anyway. So you can directly:

	select BR2_PACKAGE_PORTAUDIO if !BR2_PACKAGE_ALSA_LIB

in the BR2_PACKAGE_GNURADIO_AUDIO option.

> > > +	depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE # gnuradio    
> > 
> > This one is also annoying. Did you see the work that was posted on the
> > mailing list a while ago to allow building all variants of fftw? This
> > would allow to select the fftw package like any other. It would be
> > really really better. If you have some time to pick up this work and
> > finalize it, it would be nice.
> >   
> Thanks to highlight this patch because I've missed this one. I've,
> recently, looking at a way to build all flavors for this package
> instead of just one.
> Currently, according to the precision specified, fftw produce a dynamic
> library with a name corresponding to the precision. All others files
> (headers and doc) are the same and there are no risk with overwrite.
> I must update this patch.

That would be nice. However, there were some issues with the patch, so
it is not going to be good as-is. Make sure to read the discussion I
had with the original submitter. I remember spending quite some time
interacting with him/her to try to find a good solution (but that
wasn't trivial).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-02-13 12:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 14:01 [Buildroot] [PATCH v5] gqrx: new package Gwenhael Goavec-Merou
2017-02-12 14:53 ` Thomas Petazzoni
2017-02-13  8:38   ` gwenhael.goavec
2017-02-13 12:35     ` Thomas Petazzoni [this message]
2017-02-13 15:01       ` gwenhael.goavec
2017-02-13 15:18         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170213133507.67a46075@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox