From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bctoolbox: fix typos and logic error
Date: Tue, 14 Feb 2017 11:20:54 +0100 [thread overview]
Message-ID: <20170214112054.3e092c84@free-electrons.com> (raw)
In-Reply-To: <20170214090132.GA5012@waldemar-brodkorb.de>
Hello,
Thanks a lot for looking into this build issue and fixing it. Just one
comment below.
On Tue, 14 Feb 2017 10:01:32 +0100, Waldemar Brodkorb wrote:
> diff --git a/package/bctoolbox/0001-fix-typo.patch b/package/bctoolbox/0001-fix-typo.patch
> new file mode 100644
> index 0000000..b94daee
> --- /dev/null
> +++ b/package/bctoolbox/0001-fix-typo.patch
> @@ -0,0 +1,18 @@
> +Fix a typo in the variable name. Only check path for a single library name.
> +
> +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
When the upstream project uses Git, I really, really prefer when the
patches are Git formatted. This way, they can easily be git am'ed by
other people who need to create/rework patches for the same package.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-14 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 9:01 [Buildroot] [PATCH] bctoolbox: fix typos and logic error Waldemar Brodkorb
2017-02-14 10:17 ` Peter Korsgaard
2017-02-14 10:20 ` Thomas Petazzoni [this message]
2017-02-14 15:22 ` Jörg Krause
2017-02-14 15:39 ` Waldemar Brodkorb
2017-02-14 16:29 ` Jörg Krause
2017-02-14 19:25 ` Peter Korsgaard
2017-02-14 20:10 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214112054.3e092c84@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox