Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] kmscube: Add new package
Date: Tue, 14 Feb 2017 11:23:49 +0100	[thread overview]
Message-ID: <20170214112349.55c30c40@free-electrons.com> (raw)
In-Reply-To: <20170214092400.4g7lp3xj5z5zgxo2@lukather>

Hello,

On Tue, 14 Feb 2017 10:24:00 +0100, Maxime Ripard wrote:

> Actually, it doesn't depend on a specific GLES / EGL implementation,
> but it does depend on Mesa for GBM. There are alternative
> implementation of GBM as well, so having something like:
> 
> depends on BR2_PACKAGE_HAS_LIBEGL
> depends on BR2_PACKAGE_HAS_LIBGLES
> depends on BR2_PACKAGE_MESA3D # GBM implementation
> 
> Seems more natural

In principle, I would agree, but we pass --enable-gbm only when
BR2_PACKAGE_MESA3D_OPENGL_EGL=y. So with your proposal, we could end up
in a situation where libgbm isn't.

Try a build with just BR2_PACKAGE_MESA3D=y, libgm isn't
built/installed. So if we want to do this, perhaps we need a separate
BR2_PACKAGE_MESA3D_LIBGBM option?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-02-14 10:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 18:49 [Buildroot] [PATCH v2] kmscube: Add new package Fabio Estevam
2017-02-13 20:34 ` Gary Bisson
2017-02-13 21:31 ` Thomas Petazzoni
2017-02-13 22:03   ` Fabio Estevam
2017-02-13 23:43     ` Fabio Estevam
2017-02-14  8:18     ` Thomas Petazzoni
2017-02-14  9:24       ` Maxime Ripard
2017-02-14 10:23         ` Thomas Petazzoni [this message]
2017-02-15  8:55           ` Maxime Ripard
2017-02-15  9:04             ` Thomas Petazzoni
2017-02-14 12:30       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170214112349.55c30c40@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox