Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] sslh: new package
Date: Tue, 21 Feb 2017 22:03:23 +0100	[thread overview]
Message-ID: <20170221210323.GB3347@free.fr> (raw)
In-Reply-To: <20170221211823.4137d10f@free-electrons.com>

Thomas, David, All,

On 2017-02-21 21:18 +0100, Thomas Petazzoni spake thusly:
> On Thu, 26 Jan 2017 10:40:36 +0100, David Bachelart wrote:
> > Signed-off-by: David Bachelart <david.bachelart@bbright.com>
> > ---
> > Changes v1 -> v2:
> >   - rewrite patch (suggested by Thomas Petazzoni). sslh version is 
> >     extracted from git, but this version is corrupted if we use git 
> >     as VCS for buildroot. This new patch is a more flexible way to 
> >     handle this : the version is now extracted from git only if the
> >     sslh directory is handled by git
> >   - fix comment in Config.in file (suggested by Thomas Petazzoni)
> >   - rewrite init script (suggested by Thomas Petazzoni)
> >   - remove sslh.default file (suggested by Thomas Petazzoni)
> >   - fix sslh.mk file (suggested by Thomas Petazzoni)
> >     - indentation
> >     - version now includes "v" prefix
> >     - fix license
> >     - use install target of upstream makefile
> >   - register myself as developer for sslh in DEVELOPERS file
> > ---
> >  DEVELOPERS                                         |  1 +
> >  package/Config.in                                  |  1 +
> >  ...ion-while-building-sslh-in-a-larger-git-t.patch | 43 +++++++++++++++++++
> >  package/sslh/Config.in                             | 14 +++++++
> >  package/sslh/S35sslh                               | 48 ++++++++++++++++++++++
> >  package/sslh/sslh.hash                             |  4 ++
> >  package/sslh/sslh.mk                               | 28 +++++++++++++
> >  7 files changed, 139 insertions(+)
> >  create mode 100644 package/sslh/0001-secure-version-while-building-sslh-in-a-larger-git-t.patch
> >  create mode 100644 package/sslh/Config.in
> >  create mode 100644 package/sslh/S35sslh
> >  create mode 100644 package/sslh/sslh.hash
> >  create mode 100644 package/sslh/sslh.mk
> 
> This package is causing some build failures:
> 
>   http://autobuild.buildroot.net/?reason=sslh-v1.18
> 
> Could you investigate and provide a fix for this issue ?

The issue is caused by a UTF-* non-breaj sapce U+c2a0 on line 28 of the
script genver.sh. This should be replaced by an ASCII U+20 space.

It is usually invisible in most editors. I can see it because my vim has
a plugin that highlights such troll characters.

Patch incoming...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-02-21 21:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  9:40 [Buildroot] [PATCH v2] sslh: new package David Bachelart
2017-01-26  9:47 ` Yegor Yefremov
2017-01-27  8:37 ` Thomas Petazzoni
2017-02-21 20:18 ` Thomas Petazzoni
2017-02-21 21:03   ` Yann E. MORIN [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-01-02 15:45 [Buildroot] [PATCH v2] ifenslave: " David Bachelart
2017-01-02 15:45 ` [Buildroot] [PATCH v2] sslh: " David Bachelart
2017-01-25 10:35   ` Thomas Petazzoni
2017-01-25 11:20     ` David Bachelart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170221210323.GB3347@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox