From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2 next] Revert "reproducible: fix DATE/TIME macros in toolchain-wrapper"
Date: Tue, 21 Feb 2017 21:47:50 +0100 [thread overview]
Message-ID: <20170221214750.4c057f08@free-electrons.com> (raw)
In-Reply-To: <0db12adda90ffa9bf7a3925cf1563aea4591c5ef.1487709136.git.yann.morin.1998@free.fr>
Hello,
On Tue, 21 Feb 2017 21:32:35 +0100, Yann E. MORIN wrote:
> This reverts commit 76838f63412a30a358210e457dda4b79f7730624.
>
> The commit referenced above explicitly states that the function was
> copied as-is from the gcc source code at the time. And indeed that is
> exactly how the function appeared in gcc in commit
> e3e8c48c4a494d9da741c1c8ea6c4c0b7c4ff934.
>
> However, our toolchain wrapper is "GPLv2 only", while the file this function
> was copied from is "GPLv3 or later". As such we can't include that function
> and still comply to both licenses.
>
> Furthermore, the code is far from optimum.
>
> Since this feature is not release-critical, revert it until we re-implement
> it.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Samuel Martin <s.martin49@gmail.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This has already been applied in master:
https://git.buildroot.org/buildroot/commit/?id=1c8c0d91a431fda2c052072af87e0de35bd3b953
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-21 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 20:32 [Buildroot] [PATCH 0/2 next] toolchain/wrapper: adhere to SOURCE_DATE_EPOCH Yann E. MORIN
2017-02-21 20:32 ` [Buildroot] [PATCH 1/2 next] Revert "reproducible: fix DATE/TIME macros in toolchain-wrapper" Yann E. MORIN
2017-02-21 20:47 ` Thomas Petazzoni [this message]
2017-02-21 20:54 ` Yann E. MORIN
2017-02-21 21:01 ` Thomas Petazzoni
2017-02-22 11:50 ` Arnout Vandecappelle
2017-02-22 13:23 ` Peter Korsgaard
2017-02-22 13:44 ` Arnout Vandecappelle
2017-02-22 13:44 ` Thomas Petazzoni
2017-02-21 20:32 ` [Buildroot] [PATCH 2/2 next] toolchain/wrapper: fake __DATE_ and __TIME__ for older gcc Yann E. MORIN
2017-03-01 22:12 ` Thomas Petazzoni
2017-03-02 17:05 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221214750.4c057f08@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox