Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/sngrep: add missing ncurses dependencies
Date: Tue, 21 Feb 2017 22:41:50 +0100	[thread overview]
Message-ID: <20170221224150.6fa10b18@free-electrons.com> (raw)
In-Reply-To: <20170218154333.24496-1-romain.naour@gmail.com>

Hello,

On Sat, 18 Feb 2017 16:43:33 +0100, Romain Naour wrote:

> diff --git a/package/sngrep/Config.in b/package/sngrep/Config.in
> index 4d0d80c..70d2354 100644
> --- a/package/sngrep/Config.in
> +++ b/package/sngrep/Config.in
> @@ -5,6 +5,8 @@ config BR2_PACKAGE_SNGREP
>  	bool "sngrep"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_NCURSES
> +	select BR2_PACKAGE_NCURSES_TARGET_PANEL
> +	select BR2_PACKAGE_NCURSES_TARGET_FORM
>  	select BR2_PACKAGE_LIBPCAP

While I agree that this fixes the build, I don't think it's the right
fix. Indeed, the ncurses package is badly broken, as it installs some
libraries in staging, but not in target.

I have therefore sent a patch fixing ncurses instead:

  http://patchwork.ozlabs.org/patch/730793/

Let me know what you think about it.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

      parent reply	other threads:[~2017-02-21 21:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18 15:43 [Buildroot] [PATCH] package/sngrep: add missing ncurses dependencies Romain Naour
2017-02-18 15:49 ` Thomas Petazzoni
2017-02-18 16:03   ` Romain Naour
2017-02-18 17:23     ` Thomas Petazzoni
2017-02-18 18:21   ` Bernd Kuhls
2017-02-18 19:09     ` Romain Naour
2017-02-19  9:01     ` Thomas Petazzoni
2017-02-21 21:41 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170221224150.6fa10b18@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox