Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] glibc: install libanl.so to target
Date: Thu, 23 Feb 2017 21:41:56 +0100	[thread overview]
Message-ID: <20170223214156.5dc95fb7@free-electrons.com> (raw)
In-Reply-To: <1487848270-32609-1-git-send-email-jbb@gamblify.com>

Hello,

On Thu, 23 Feb 2017 12:11:10 +0100, Jesper B?kdahl wrote:
> Signed-off-by: Jesper B?kdahl <jbb@gamblify.com>

Thanks for your contribution. However, could you extend the commit log
to explain briefly in which situations is this library used?

In addition, you should also adjust the TOOLCHAIN_EXTERNAL_LIBS
variable in toolchain/toolchain-external/pkg-toolchain-external.mk to
be consistent.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-02-23 20:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 11:11 [Buildroot] [PATCH 1/1] glibc: install libanl.so to target Jesper Bækdahl
2017-02-23 20:41 ` Thomas Petazzoni [this message]
2017-02-24  9:03 ` [Buildroot] [PATCH v2 1/2] " Jesper Bækdahl
2017-02-24  9:03   ` [Buildroot] [PATCH v2 2/2] toolchain-external: install libanl.so for glibc Jesper Bækdahl
2017-02-25 15:44     ` Thomas Petazzoni
2017-02-25 15:44   ` [Buildroot] [PATCH v2 1/2] glibc: install libanl.so to target Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223214156.5dc95fb7@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox