From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/2] package/directfb,sdl: fix static link
Date: Thu, 23 Feb 2017 22:50:56 +0100 [thread overview]
Message-ID: <20170223225056.57bdac3f@free-electrons.com> (raw)
In-Reply-To: <cover.1487885342.git.yann.morin.1998@free.fr>
Hello,
On Thu, 23 Feb 2017 22:29:19 +0100, Yann E. MORIN wrote:
> Yann E. MORIN (2):
> package/directfb: hack .pc file for static link
> package/sdl: fix .pc file
Thanks for working on this. However, can we instead patch the directfb
and sdl build system?
For example, the SDL build system should not add -ldirect to Libs: if
DirectFB was detected with pkg-config, it should add it to the
Requires: line.
For DirectFB, I think libstdc++ could be unconditionally added to
directfb.pc.in.
*But*: let's take a step back. Do we really care about using DirectFB
in static-only scenarios ? If only DirectFB and SDL were active
upstream projects, there would be some incentive to fix this problem
properly. But really, there is no such incentive. So what about making
DirectFB depend on !BR2_STATIC_LIBS instead, and be done with it ?
Nowhere in Buildroot we "select BR2_PACKAGE_DIRECTFB", which means it's
really a simple change to do, as we don't need to propagate this
dependency to any reverse dependency.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-02-23 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 21:29 [Buildroot] [PATCH 0/2] package/directfb,sdl: fix static link Yann E. MORIN
2017-02-23 21:29 ` [Buildroot] [PATCH 1/2] package/directfb: hack .pc file for " Yann E. MORIN
2017-02-23 21:29 ` [Buildroot] [PATCH 2/2] package/sdl: fix .pc file Yann E. MORIN
2017-02-23 21:50 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223225056.57bdac3f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox