From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/python: apply unicode config to host build
Date: Thu, 23 Feb 2017 23:13:37 +0100 [thread overview]
Message-ID: <20170223231337.20304671@free-electrons.com> (raw)
In-Reply-To: <20170222031423.GA2574@csmart.io>
Hello,
On Wed, 22 Feb 2017 14:14:23 +1100, Chris Smart wrote:
> Currently the host build of Python 2 defaults to narrow unicode (UCS2),
> ignoring the BR2_PACKAGE_PYTHON_UCS4 configuration option which may be
> set to wide (UCS4).
>
> This results in host and target Python packages which are incompatible
> in subtle ways.
>
> For example, installing wheels into the target fails when they are made
> with the host python, citing incompatibility (as can be seen by the
> package tags which may be "cp27u-manylinux1" instead of
> "cp27mu-manylinux1").
>
> Compiling the host Python 2 with the same UCS configuration as the
> target ensures that the packages are compatible (and the tags match).
>
> This does not affect Python 3 as support for narrow unicode was
> deprecated in version 3.3, see https://www.python.org/dev/peps/pep-0393/
>
> Thanks to Tony Breeds <tony@bakeyournoodle.com> for reporting this.
>
> Signed-off-by: Chris Smart <mail@csmart.io>
> ---
> package/python/python.mk | 1 +
> 1 file changed, 1 insertion(+)
Applied to master, after adding a comment in the code itself to explain
why we're doing this.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-23 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 3:14 [Buildroot] [PATCH] package/python: apply unicode config to host build Chris Smart
2017-02-23 22:13 ` Thomas Petazzoni [this message]
2017-02-23 23:33 ` Chris Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223231337.20304671@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox