Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] pru-software-support: bump version to 5.1.0
Date: Sat, 25 Feb 2017 11:31:17 +0100	[thread overview]
Message-ID: <20170225103117.GB3627@free.fr> (raw)
In-Reply-To: <20170225091424.GA3627@free.fr>

Cam, All,

On 2017-02-25 10:14 +0100, Yann E. MORIN spake thusly:
> On 2017-02-24 22:44 +0000, Cam Mannett spake thusly:
> > Signed-off-by: Cam Mannett <camden.mannett@protonmail.ch>
> > ---
> >  package/pru-software-support/pru-software-support.hash |  2 +-
> >  package/pru-software-support/pru-software-support.mk   | 17 ++++++++++++++---
> >  2 files changed, 15 insertions(+), 4 deletions(-)
> > 
> > diff --git a/package/pru-software-support/pru-software-support.hash b/package/pru-software-support/pru-software-support.hash
> > index 8f624da..08ca8d2 100644
> > --- a/package/pru-software-support/pru-software-support.hash
> > +++ b/package/pru-software-support/pru-software-support.hash
> > @@ -1,2 +1,2 @@
> >  # Locally-calculated hash
> > -sha256	b257535ca9b1641d1a238795f3c7004064c573a91cf4a1fa566e3f7c2360c38f	pru-software-support-804b548e69ef9fdf44445f6d0968d81cb8a1e7b4.tar.gz
> > +sha256	1e880d74f9a1d04324e6255cb7a0e3d40f92e08809dc81dc6c714447bac5c335	v5.1.0
> > diff --git a/package/pru-software-support/pru-software-support.mk b/package/pru-software-support/pru-software-support.mk
> > index 06983c2..2b29efe 100644
> > --- a/package/pru-software-support/pru-software-support.mk
> > +++ b/package/pru-software-support/pru-software-support.mk
> > @@ -4,13 +4,24 @@
> >  #
> >  ################################################################################
> >  
> > -PRU_SOFTWARE_SUPPORT_VERSION = 804b548e69ef9fdf44445f6d0968d81cb8a1e7b4
> > -PRU_SOFTWARE_SUPPORT_SITE = git://git.ti.com/pru-software-support-package/pru-software-support-package.git
> > +PRU_SOFTWARE_SUPPORT_VERSION = v5.1.0
> > +PRU_SOFTWARE_SUPPORT_SOURCE = $(PRU_SOFTWARE_SUPPORT_VERSION)
> > +PRU_SOFTWARE_SUPPORT_SITE = https://git.ti.com/pru-software-support-package/pru-software-support-package/archive-tarball
> 
> Please don't do that. This will generate an archive named just 'v5.1.0'
> without the name of the package. This is highly inconvenient.
> 
> Please do as Arnout suggested (note the trailing '?' in the site):
> 
>     PRU_SOFTWARE_SUPPORT_VERSION = v5.1.0
>     PRU_SOFTWARE_SUPPORT_SITE = https://git.ti.com/pru-software-support-package/pru-software-support-package/archive-tarball/$(PRU_SOFTWARE_SUPPORT_VERSION)?
> 
> This will guarantee that the local file is correctly named to
> pru-software-support-v5.1.0.tar.gz
> 
> Also, it seems that gitorious is generating reproducible archives, so
> please do provide a hash. You can check if it is reproducible, the sha1
> I got here was:
>     f23e64c9adf0739a7dc73a31e5d7bb798c9e5dd0  pru-software-support-v5.1.0.tar.gz

Damn, I just noticed that you did provide a hash. My bad.

Furthermore, I can confirm that the hash mathes what I downloaded here.

Regards,
Yann E. MORIN.

> Regards,
> Yann E. MORIN.
> 
> >  PRU_SOFTWARE_SUPPORT_LICENSE =  BSD-3c, GPLv2, Public Domain
> > -PRU_SOFTWARE_SUPPORT_LICENSE_FILES = PRU-Package-v4.0-Manifest.html
> > +PRU_SOFTWARE_SUPPORT_LICENSE_FILES = PRU-Package-v5.0-Manifest.html
> >  PRU_SOFTWARE_SUPPORT_DEPENDENCIES = host-ti-cgt-pru host-pru-software-support
> >  HOST_PRU_SOFTWARE_SUPPORT_DEPENDENCIES = host-ti-cgt-pru
> >  
> > +PRU_SOFTWARE_SUPPORT_EXTRACT_CMD = tar -C $(@D) --strip-components=1 -xzf $(DL_DIR)/$(PRU_SOFTWARE_SUPPORT_SOURCE)
> > +
> > +define PRU_SOFTWARE_SUPPORT_EXTRACT_CMDS
> > +	$(PRU_SOFTWARE_SUPPORT_EXTRACT_CMD)
> > +endef
> > +
> > +define HOST_PRU_SOFTWARE_SUPPORT_EXTRACT_CMDS
> > +	$(PRU_SOFTWARE_SUPPORT_EXTRACT_CMD)
> > +endef
> > +
> >  define HOST_PRU_SOFTWARE_SUPPORT_BUILD_CMDS
> >  	$(MAKE) PRU_CGT=$(TI_CGT_PRU_INSTALLDIR) -C $(@D)/lib/src
> >  endef
> > -- 
> > 2.9.3
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-02-25 10:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 22:44 [Buildroot] [PATCH 1/2] pru-software-support: bump version to 5.1.0 Cam Mannett
2017-02-25  9:14 ` Yann E. MORIN
2017-02-25 10:31   ` Yann E. MORIN [this message]
2017-02-25 14:16   ` Arnout Vandecappelle
  -- strict thread matches above, loose matches on Subject: below --
2017-02-25  8:16 Cam Mannett
2017-02-25  8:23 camden.mannett at gmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170225103117.GB3627@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox