From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-cmake: pass <pkg>_CONF_ENV for the target configure step
Date: Sun, 26 Feb 2017 19:02:36 +0100 [thread overview]
Message-ID: <20170226190236.3889bf4c@free-electrons.com> (raw)
In-Reply-To: <20170226175848.GD4043@free.fr>
Hello,
On Sun, 26 Feb 2017 18:58:48 +0100, Yann E. MORIN wrote:
> > diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> > index 4e0e838..a7c8dc3 100644
> > --- a/package/pkg-cmake.mk
> > +++ b/package/pkg-cmake.mk
> > @@ -109,7 +109,7 @@ define $(2)_CONFIGURE_CMDS
> > cd $$($$(PKG)_BUILDDIR) && \
> > rm -f CMakeCache.txt && \
> > PATH=$$(BR_PATH) \
> > - $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
> > + $$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
>
> I would have written the extra env on its own line, like is done in e.g.
> pkg-autotools:
Expect that's not how it's done currently for the host variant of
pkg-cmake, i.e it's done like I'm proposing in my patch. So for
consistency, I prefer my option (and possibly a follow-up patch making
both the host and target variant consistent with pkg-autotools.mk).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-26 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 17:42 [Buildroot] [PATCH] pkg-cmake: pass <pkg>_CONF_ENV for the target configure step Thomas Petazzoni
2017-02-26 17:58 ` Yann E. MORIN
2017-02-26 18:02 ` Thomas Petazzoni [this message]
2017-02-26 21:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170226190236.3889bf4c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox