From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 2 Mar 2017 21:37:41 +0100 Subject: [Buildroot] [PATCH] package/alsamixergui: add license information In-Reply-To: References: <20170302171632.0b2fa9b5@free-electrons.com> Message-ID: <20170302213741.63b86f2a@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, Please keep the Buildroot mailing list in Cc. Thanks! On Thu, 2 Mar 2017 18:28:08 +0100, Wolfgang Grandegger wrote: > "make legal-info" did report that the license is unkown. Yes, before your patch. What I suggested is that you should run "make legal-info" after your patch. > Then I looked > into "build/alsamixergui...". The COPYING file seems to be generated by make: > > $ make alsamixergui-dirclean > $ make alsamixergui-extract > $ head build/alsamixergui-0.9.0rc2-1/COPYING > head: cannot open 'build/alsamixergui/COPYING' for reading: No such file or directory > $ make alsamixergui > $ head build/alsamixergui-0.9.0rc2-1/COPYING OK, but that doesn't work, because you have no guarantee that the package has been built when "make legal-info" runs. "make legal-info" only ensures that packages have been: 1. downloaded, 2. extracted, 3. patched. So, with your patch applied, if you run: $ make clean $ make legal-info then you will see that it fails, because the COPYING file doesn't exist. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com