From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ncftp: fix host/target confusion
Date: Thu, 2 Mar 2017 21:43:46 +0100 [thread overview]
Message-ID: <20170302214346.1157dda6@free-electrons.com> (raw)
In-Reply-To: <CANxTyt6tGknGoHc2swaeqh-h6L740Ny79UwgH4AqQH2SfjQYnQ@mail.gmail.com>
Hello,
On Thu, 2 Mar 2017 11:07:55 -0800, Danomi Manchego wrote:
> Are you able to download this tarball with the hash indicated in
> ncftp.hash? I keep getting an error:
>
> ERROR: ncftp-3.2.6-src.tar.xz has wrong sha256 hash:
> ERROR: expected:
> 7abd3e8f848f0efb4bb6a4bc5da58a59524d4378fc8d70a52adb0fe1fd00b89d
> ERROR: got :
> 5f200687c05d0807690d9fb770327b226f02dd86155b49e750853fce4e31098d
> ERROR: Incomplete download, or man-in-the-middle (MITM) attack
It seems like the tarball has been re-generated and republished by
upstream.
Indeed, a diff between the two shows:
-3.2.6, 2016-12-04
+3.2.6, 2016-09-23
(where the - lines are the tarball from the upstream site, which is
newer, and the + lines are the tarball from sources.buildroot.net). And
interestingly, the web page at
http://www.ncftp.com/ncftp/doc/changelog.html pretends that the 3.2.6
version has been released on 2016-11-27...
And the diffstat is actually not that small:
Strn/DStrInternal.h | 4
Strn/Strn.h | 2
autoconf_local/acconfig.h | 8
autoconf_local/aclocal.m4 | 116 ---
config.h.in | 8
configure | 1701 ++++++++++++++++++++--------------------------
configure.in | 9
doc/CHANGELOG.txt | 2
libncftp/c_opennologin.c | 4
libncftp/ftp.c | 31
libncftp/ftw.c | 2
libncftp/io_getmem.c | 2
libncftp/io_list.c | 6
libncftp/io_sendfile.c | 4
libncftp/io_util.c | 4
libncftp/ncftp.h | 2
libncftp/open.c | 4
libncftp/rftw.c | 2
libncftp/rglobr.c | 2
libncftp/u_decodehost.c | 2
libncftp/u_decodeurl.c | 2
libncftp/u_getpass.c | 2
libncftp/u_misc.c | 2
libncftp/u_pathcat.c | 4
libncftp/u_scram.c | 2
libncftp/wincfg.h | 1
ncftp/cmds.c | 38 -
ncftp/gl_getline.c | 26
ncftp/ls.c | 9
ncftp/ls.h | 9
ncftp/progress.c | 9
ncftp/readln.c | 4
ncftp/shell.h | 10
ncftp/spoolutil.c | 8
ncftp/version.c | 2
sh/mksrctar.sh | 1
sh_util/gpshare.c | 12
sh_util/ncftpbatch.c | 110 --
sh_util/ncftpget.c | 6
sh_util/ncftpls.c | 5
sh_util/ncftpput.c | 14
sio/DNSUtil.c | 4
sio/Makefile.in | 16
sio/SBind.c | 35
sio/SConnect.c | 9
sio/SNew.c | 115 ---
sio/SRead.c | 6
sio/StrAddr.c | 6
sio/config.h.in | 24
sio/configure.in | 8
sio/sio.h | 18
sio/wincfg.h | 1
vis/bmed.c | 13
vis/wgets.c | 12
vis/wgets.h | 7
vis/wutil.c | 6
vis/wutil.h | 6
win/bmed/bmed.vcproj | 4
I'm not sure what to do in this case? Blindly take the new upstream
version? Complain to upstream?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-02 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 22:54 [Buildroot] [PATCH] ncftp: fix host/target confusion Thomas Petazzoni
2017-03-01 20:13 ` Yann E. MORIN
2017-03-01 20:48 ` Thomas Petazzoni
2017-03-02 16:28 ` Peter Korsgaard
2017-03-02 19:07 ` Danomi Manchego
2017-03-02 20:43 ` Thomas Petazzoni [this message]
2017-03-03 20:50 ` Peter Korsgaard
2017-03-03 22:04 ` Arnout Vandecappelle
2017-03-03 22:08 ` Peter Korsgaard
2017-03-07 16:48 ` Peter Korsgaard
2017-03-07 20:10 ` Thomas Petazzoni
2017-03-07 21:10 ` Peter Korsgaard
2017-04-14 22:35 ` Arnout Vandecappelle
2017-04-26 6:48 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302214346.1157dda6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox