Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/librsvg: disable gdk-pixbuf-loader
Date: Sat, 4 Mar 2017 11:56:06 +0100	[thread overview]
Message-ID: <20170304115606.76da14f6@free-electrons.com> (raw)
In-Reply-To: <20170304103503.18877-1-romain.naour@gmail.com>

Hello,

On Sat,  4 Mar 2017 11:35:03 +0100, Romain Naour wrote:
> gdk-pixbuf-loader support is enabled by default but it silently fail to
> generate gdk-pixbuf.loaders file when host != target.
> 
> For exemple on ARM target:
> output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
> g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la: output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so: wrong ELF class: ELFCLASS32
> 
> But it doesn't break the build.
> 
> When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain
> optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the
> build due to "Illegal instruction".
> 
> output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la
> Illegal instruction (core dumped)
> 
> Since this option is broken for cross-compilation, disable it.
> 
> Fixes:
> http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/librsvg/librsvg.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. Peter: I believe this should go in the LTS
branch.

Gustavo: let me know if you're happy with this solution. If not, don't
hesitate to provide an alternative solution.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2017-03-04 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-04 10:35 [Buildroot] [PATCH] package/librsvg: disable gdk-pixbuf-loader Romain Naour
2017-03-04 10:56 ` Thomas Petazzoni [this message]
2017-03-04 11:01   ` Romain Naour
2017-03-07 12:20   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170304115606.76da14f6@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox