[Buildroot] [PATCH] package/librsvg: disable gdk-pixbuf-loader

[Buildroot] [PATCH] package/librsvg: disable gdk-pixbuf-loader

[Romain Naour]

gdk-pixbuf-loader support is enabled by default but it silently fail to
generate gdk-pixbuf.loaders file when host != target.

For exemple on ARM target:
output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la: output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so: wrong ELF class: ELFCLASS32

But it doesn't break the build.

When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain
optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the
build due to "Illegal instruction".

output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la
Illegal instruction (core dumped)

Since this option is broken for cross-compilation, disable it.

Fixes:
http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 package/librsvg/librsvg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/librsvg/librsvg.mk b/package/librsvg/librsvg.mk
index b711de4..db57193 100644
--- a/package/librsvg/librsvg.mk
+++ b/package/librsvg/librsvg.mk
@@ -9,7 +9,7 @@ LIBRSVG_VERSION = $(LIBRSVG_VERSION_MAJOR).16
 LIBRSVG_SITE = http://ftp.gnome.org/pub/gnome/sources/librsvg/$(LIBRSVG_VERSION_MAJOR)
 LIBRSVG_SOURCE = librsvg-$(LIBRSVG_VERSION).tar.xz
 LIBRSVG_INSTALL_STAGING = YES
-LIBRSVG_CONF_OPTS = --disable-tools --enable-introspection=no
+LIBRSVG_CONF_OPTS = --disable-pixbuf-loader --disable-tools --enable-introspection=no
 HOST_LIBRSVG_CONF_OPTS = --enable-introspection=no
 LIBRSVG_DEPENDENCIES = cairo host-gdk-pixbuf gdk-pixbuf libcroco libglib2 libxml2 pango \
 	$(if $(BR2_PACKAGE_LIBGTK3),libgtk3)
-- 
2.9.3

[Buildroot] [PATCH] package/librsvg: disable gdk-pixbuf-loader

[Thomas Petazzoni]

Hello,

On Sat,  4 Mar 2017 11:35:03 +0100, Romain Naour wrote:
> gdk-pixbuf-loader support is enabled by default but it silently fail to
> generate gdk-pixbuf.loaders file when host != target.
> 
> For exemple on ARM target:
> output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
> g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la: output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so: wrong ELF class: ELFCLASS32
> 
> But it doesn't break the build.
> 
> When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain
> optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the
> build due to "Illegal instruction".
> 
> output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la
> Illegal instruction (core dumped)
> 
> Since this option is broken for cross-compilation, disable it.
> 
> Fixes:
> http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
>  package/librsvg/librsvg.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. Peter: I believe this should go in the LTS
branch.

Gustavo: let me know if you're happy with this solution. If not, don't
hesitate to provide an alternative solution.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] package/librsvg: disable gdk-pixbuf-loader

[Romain Naour]

Hi Thomas, All,

Le 04/03/2017 ? 11:56, Thomas Petazzoni a ?crit :
> Hello,
> 
> On Sat,  4 Mar 2017 11:35:03 +0100, Romain Naour wrote:
>> gdk-pixbuf-loader support is enabled by default but it silently fail to
>> generate gdk-pixbuf.loaders file when host != target.
>>
>> For exemple on ARM target:
>> output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
>> g_module_open() failed for output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la: output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so: wrong ELF class: ELFCLASS32
>>
>> But it doesn't break the build.
>>
>> When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain
>> optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the
>> build due to "Illegal instruction".
>>
>> output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la
>> Illegal instruction (core dumped)
>>
>> Since this option is broken for cross-compilation, disable it.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> ---
>>  package/librsvg/librsvg.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to master, thanks. Peter: I believe this should go in the LTS
> branch.
> 
> Gustavo: let me know if you're happy with this solution. If not, don't
> hesitate to provide an alternative solution.

I just found an upstream patch disabling gdk-pixbuf.loaders build when
cross-compiling:

https://github.com/GNOME/librsvg/commit/30a91d1e1f2df9ad4d6b28ed635e69619b1ed8b3

Best regards,
Romain

> 
> Thanks!
> 
> Thomas
> 

[Buildroot] [PATCH] package/librsvg: disable gdk-pixbuf-loader

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Sat,  4 Mar 2017 11:35:03 +0100, Romain Naour wrote:
 >> gdk-pixbuf-loader support is enabled by default but it silently fail to
 >> generate gdk-pixbuf.loaders file when host != target.
 >> 
 >> For exemple on ARM target:
 >> output/host/usr/bin/gdk-pixbuf-query-loaders ./libpixbufloader-svg.la
 >> g_module_open() failed for
 >> output/build/librsvg-2.40.16/gdk-pixbuf-loader/./libpixbufloader-svg.la:
 >> output/build/librsvg-2.40.16/gdk-pixbuf-loader/./.libs/libpixbufloader-svg.so:
 >> wrong ELF class: ELFCLASS32
 >> 
 >> But it doesn't break the build.
 >> 
 >> When host = target using the Sourcery CodeBench AMD64 2016.11 toolchain
 >> optimized for x86_68 AMD Puma/Jaguar or AMD Steamroller, it break the
 >> build due to "Illegal instruction".
 >> 
 >> output/host/usr/bin/gdk-pixbuf-query-loaders libpixbufloader-svg.la
 >> Illegal instruction (core dumped)
 >> 
 >> Since this option is broken for cross-compilation, disable it.
 >> 
 >> Fixes:
 >> http://autobuild.buildroot.net/results/393/393145bc9bcb93d6df55ec8c63725c3d9a299957
 >> 
 >> Signed-off-by: Romain Naour <romain.naour@gmail.com>
 >> ---
 >> package/librsvg/librsvg.mk | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)

 > Applied to master, thanks. Peter: I believe this should go in the LTS
 > branch.

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard