Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] odroid-mali: mark package as BROKEN
Date: Sun, 5 Mar 2017 23:37:27 +0100	[thread overview]
Message-ID: <20170305223726.GM3671@free.fr> (raw)
In-Reply-To: <b81cad7b-504e-b927-3f62-844925aba881@mind.be>

Arnout, All,

On 2017-03-05 23:33 +0100, Arnout Vandecappelle spake thusly:
> On 05-03-17 21:37, Thomas Petazzoni wrote:
> > On Sat,  4 Mar 2017 15:34:19 +0100, Thomas Petazzoni wrote:
> >> The version of the khrplatform.h header bundled with odroid-mali has a
> >> definition of the khronos_intptr_t and khronos_ssize_t that doesn't
> >> match the official Khronos registry headers or the Mesa3D headers. Due
> >> to this, it causes conflicts with some packages that redefines those
> >> types (with the correct definitions), such as libepoxy.
> >>
> >> Issue reported upstream at: https://github.com/mdrjr/c2_mali/issues/1
> >>
> >> Since nobody bothered fixing the issue even though it has been happening
> >> since July 2016 (first build failure at
> >> http://autobuild.buildroot.net/results/ed8d562ae5fdb472a83f9a07b2f755c80c972c34/),
> >> let's mark this package as BROKEN.
> >>
> >> Fixes:
> >>
> >>   http://autobuild.buildroot.net/results/ca48bb6291ca16e410edb83b5cdeb24847b6eaee/
> >>
> >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >> ---
> >>  package/odroid-mali/Config.in | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> > 
> > Applied to master, thanks.
> 
>  I'm obviously late with commenting on this, but I think marking things as
> BROKEN is wrong. It bypasses the legacy mechanism so it disappears without
> notice. Also, BROKEN packages languish there for years without ever anyone
> taking a look. Sometimes things do get repaired, but re-adding the package is
> not much more complicated than
> 
>  So, I propose to remove all broken packages.

Agreed.

>  [I have the feeling we discussed this kind of thing at some BR devel meeting at
> some point, but I can't find it.]

Yes we did. And IIRC we agreed to get rid of BROKEN altogether.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2017-03-05 22:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-04 14:34 [Buildroot] [PATCH] odroid-mali: mark package as BROKEN Thomas Petazzoni
2017-03-05 13:20 ` Yann E. MORIN
2017-03-05 20:37 ` Thomas Petazzoni
2017-03-05 22:33   ` Arnout Vandecappelle
2017-03-05 22:37     ` Yann E. MORIN [this message]
2017-03-07 15:42       ` Peter Korsgaard
2017-03-07 17:05         ` Arnout Vandecappelle
2017-03-07 22:56           ` Thomas Petazzoni
2017-03-08  6:55             ` daggs
2017-03-08  8:02               ` Thomas Petazzoni
2017-03-05 22:40     ` Thomas Petazzoni
2017-03-05 23:35       ` Arnout Vandecappelle
2017-03-06  8:13         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170305223726.GM3671@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox