From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] lighttpd: source default file from startup script
Date: Wed, 8 Mar 2017 21:11:24 +0100 [thread overview]
Message-ID: <20170308211124.50d94081@free-electrons.com> (raw)
In-Reply-To: <20170308152114.14851-1-philipp.skadorov@savoirfairelinux.com>
Hello,
On Wed, 8 Mar 2017 10:21:14 -0500, Philipp Skadorov wrote:
> lighttpd server runs cgi application that has no way to get environment
> variables that are set up for it.
>
> S50lighttpd is changed to source /etc/default/lighttpd file where these
> environment variables can be set up.
>
> Signed-off-by: Philipp Skadorov <philipp.skadorov@savoirfairelinux.com>
There is a mismatch between the commit log (which only talks about
sourcing a default file) and the actual commit which not only sources a
default file, but also refactors other aspects of the init script to
use variables.
So this should probably be two separate commits, or at the very least
be mentioned in the commit log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-08 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 15:21 [Buildroot] [PATCH 1/1] lighttpd: source default file from startup script Philipp Skadorov
2017-03-08 17:34 ` Baruch Siach
2017-03-08 18:44 ` Philipp Skadorov
2017-03-08 18:57 ` Baruch Siach
2017-03-08 20:11 ` Thomas Petazzoni [this message]
2017-03-08 20:43 ` [Buildroot] [PATCH v2 1/2] lighttpd: carry common keywords out to variables Philipp Skadorov
2017-03-08 20:43 ` [Buildroot] [PATCH v2 2/2] lighttpd: source default file from startup script Philipp Skadorov
2017-03-09 20:53 ` [Buildroot] [PATCH v2 1/2] lighttpd: carry common keywords out to variables Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308211124.50d94081@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox