From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well
Date: Thu, 9 Mar 2017 23:02:05 +0100 [thread overview]
Message-ID: <20170309230205.3b1cdee5@free-electrons.com> (raw)
In-Reply-To: <20170309220044.GA3785@free.fr>
Hello,
On Thu, 9 Mar 2017 23:00:44 +0100, Yann E. MORIN wrote:
> > > - if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> > > + if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then
> >
> > To be honest, I wasn't sure if we wanted > or >> here. It matters if
> > you restart the test-pkg command after fixing issues. Do you want
> > logfiles to contain the log of all previous builds, or just the current
> > build?
> >
> > For now, I've applied your patch as-is, with just ">", which means the
> > logfile will only contain the output of the last build. It seems better
> > to me this way, but we'll see if other folks disagree.
>
> Using append-redirection is what we should have used here, because the
> logfile is already created a few lines above, for olddefconfig.
Hu? We're precisely changing the olddefconfig line in this patch. Am I
missing something?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-09 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 15:15 [Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well Benoît Allard
2017-03-09 20:36 ` Thomas Petazzoni
2017-03-09 22:00 ` Yann E. MORIN
2017-03-09 22:02 ` Thomas Petazzoni [this message]
2017-03-09 22:05 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309230205.3b1cdee5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox