Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/firejail: mark as broken
Date: Sun, 12 Mar 2017 15:37:58 +0100	[thread overview]
Message-ID: <20170312153758.169f00a3@free-electrons.com> (raw)
In-Reply-To: <1489325570-3550-1-git-send-email-yann.morin.1998@free.fr>

Hello,

On Sun, 12 Mar 2017 14:32:50 +0100, Yann E. MORIN wrote:
> The firejail package does not cross-compile at all, because it is not
> using automake, but a hand-written Makefile.in. So it does not use the
> cross-compiler found by ./configure.
> 
> But when we fix it by passing:
>     FIREJAIL_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
> 
> it then fails to build with symbols redefinitions:
> 
>     /home/ymorin/dev/buildroot/O/host/usr/bin/arm-linux-gnueabihf-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -ggdb  -O2 -DVERSION='"0.9.44.8"' -fstack-protector-all -D_FORTIFY_SOURCE=2 -fPIC -Wformat -Wformat-security  -c libtrace.c -o libtrace.o
>     /tmpfs/cckgOLVz.s: Assembler messages:
>     /tmpfs/cckgOLVz.s:1115: Error: symbol `stat64' is already defined
>     /tmpfs/cckgOLVz.s:1282: Error: symbol `lstat64' is already defined
>     /tmpfs/cckgOLVz.s:2296: Error: symbol `fopen64' is already defined
>     /tmpfs/cckgOLVz.s:2631: Error: symbol `freopen64' is already defined
>     Makefile:16: recipe for target 'libtrace.o' failed
> 
> (ditto for libtracelog)
> 
> Fixing this is not trivial, so we just mark the package as broken.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Chris Frederick <chrisf@cdf123.net>
> 
> ---
> If the package is not fixed before 2017.05-rc1, we will remove it
> altogether (as it was never part of an official release so far).
> ---
>  package/firejail/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, after adding "depends on BROKEN" also on the
Config.in comment, to avoid having it showing up even with the package
itself being broken.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2017-03-12 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-12 13:32 [Buildroot] [PATCH] package/firejail: mark as broken Yann E. MORIN
2017-03-12 14:37 ` Thomas Petazzoni [this message]
2017-05-28 13:37 ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312153758.169f00a3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox