From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] gst1-vaapi: add optional encoder support.
Date: Sun, 12 Mar 2017 21:52:48 +0100 [thread overview]
Message-ID: <20170312215248.02090698@free-electrons.com> (raw)
In-Reply-To: <20170201131854.3046-2-Adamduskett@outlook.com>
Hello,
On Wed, 1 Feb 2017 08:18:54 -0500, Adam Duskett wrote:
> +if BR2_PACKAGE_GST1_VAAPI
> +
> +config BR2_PACKAGE_GST1_VAAPI_ENCODERS
> + bool "Build encoders"
Changed to:
bool "enable encoders"
> +ifneq ($(BR2_PACKAGE_GST1_VAAPI_ENCODERS),y)
> + GST1_VAAPI_CONF_OPTS += --disable-encoders
This line should not be indented.
> +endif
Also, we normally explicitly enable and disable, so I've changed this
to:
+ifeq ($(BR2_PACKAGE_GST1_VAAPI_ENCODERS),y)
+GST1_VAAPI_CONF_OPTS += --enable-encoders
+else
+GST1_VAAPI_CONF_OPTS += --disable-encoders
+endif
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-12 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 13:18 [Buildroot] [PATCH 1/2] gst1-vaapi: new package Adam Duskett
2017-02-01 13:18 ` [Buildroot] [PATCH 2/2] gst1-vaapi: add optional encoder support Adam Duskett
2017-03-12 20:52 ` Thomas Petazzoni [this message]
2017-02-01 21:30 ` [Buildroot] [PATCH 1/2] gst1-vaapi: new package Thomas Petazzoni
2017-02-03 13:08 ` Adam Duskett
2017-02-07 14:07 ` Adam Duskett
2017-03-12 20:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170312215248.02090698@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox