Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] domoticz: fix build on powerpc64le
Date: Sun, 12 Mar 2017 23:47:57 +0100	[thread overview]
Message-ID: <20170312234757.074092cb@free-electrons.com> (raw)
In-Reply-To: <1487006691-34766-1-git-send-email-fontaine.fabrice@gmail.com>

Hello,

On Mon, 13 Feb 2017 18:24:51 +0100, Fabrice Fontaine wrote:
> There is an issue with powerpc64le and boost::uuids::random_generator on the
> following line of code (from include/boost/uuid/seed_rng.hpp):
> sha.process_bytes( (unsigned char const*)&std::rand, sizeof( void(*)() ) )
> This line "inspects the first couple bytes (here eight) of the std::rand
> function to seed some rng. Due to the implementation of process_bytes and
> inlining happening, it seems that one of the loops therein uses &rand-1 as
> some boundary, compiling with -O0 makes that reloc come out as 'rand + 0' and
> the link will succeed."
> See: https://bugzilla.suse.com/show_bug.cgi?id=955832#c7
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/454c0ea393615bae2d1b44be9920f25b5c49fc33
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/domoticz/domoticz.mk | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)

I'm not a big fan of the fix, but nobody came up with a better
solution, so I've applied your patch. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2017-03-12 22:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 17:24 [Buildroot] [PATCH 1/1] domoticz: fix build on powerpc64le Fabrice Fontaine
2017-03-12 22:47 ` Thomas Petazzoni [this message]
2017-03-13 23:14   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312234757.074092cb@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox