Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] binutils now adds sysroot for ld -rpath search
Date: Tue, 14 Mar 2017 22:20:24 +0100	[thread overview]
Message-ID: <20170314222024.7fe9af37@free-electrons.com> (raw)
In-Reply-To: <1489484038.1572.7.camel@embedded.rocks>

Hello,

On Tue, 14 Mar 2017 10:33:58 +0100, J?rg Krause wrote:

> After a discussion with Brad King on the CMake issue tracker [1] about
> how the linker should handle -rpath we agreed that ld should add the
> sysroot when searching for files (but not when setting the RPATH header
> value).
> 
> I picked up a five years old patch from the binutils mailing list [2]
> which already proposed the change, but was not submitted then.
> 
> I resend the patch [3] and this time Alan Modra accepted the change. He
> submitted two patches [4,5] which will add the sysroot to -rpath?for
> absolute paths.

Aaah indeed. I also recently looked at some package that was failing to
build because -rpath /usr/lib was passed. And then I realized that
things were clunky: what if you really a RPATH to be encoded in the
generated binary, but don't want this path to be looked at on the build
machine during the cross-compilation.

Your patch solves exactly that. I guess we'll have to integrate it in
Buildroot as well, but we will still have issues with external
toolchains, sadly :-/

Thanks a lot for this work!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-03-14 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14  9:33 [Buildroot] binutils now adds sysroot for ld -rpath search Jörg Krause
2017-03-14 21:20 ` Thomas Petazzoni [this message]
2017-03-15  7:45   ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314222024.7fe9af37@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox