From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libscrypt: -fPIC is needed to build for MIPS
Date: Tue, 14 Mar 2017 22:21:36 +0100 [thread overview]
Message-ID: <20170314222136.3c33c3dd@free-electrons.com> (raw)
In-Reply-To: <20170314154002.43673-1-Vincent.Riera@imgtec.com>
Hello,
On Tue, 14 Mar 2017 15:40:02 +0000, Vicente Olivert Riera wrote:
> +# -fPIC is needed to build for MIPS
> +ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el),y)
> +LIBSCRYPT_CFLAGS += -fPIC
> +endif
This is not really the proper fix, because:
1. -fPIC is not only needed for MIPS.
2. The Makefile already passes -fPIC, but it gets overridden because
Buildroot passes its own CFLAGS.
So I believe the patch proposed by Stefan S?rensen at
http://patchwork.ozlabs.org/patch/738605/ is a more appropriate
solution.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-03-14 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:40 [Buildroot] [PATCH] libscrypt: -fPIC is needed to build for MIPS Vicente Olivert Riera
2017-03-14 21:21 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314222136.3c33c3dd@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox