From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt: add enable for truetype font installation
Date: Tue, 14 Mar 2017 22:58:24 +0100 [thread overview]
Message-ID: <20170314225824.04ed09ed@free-electrons.com> (raw)
In-Reply-To: <20170310194327.489b9398@gmx.net>
Hello,
On Fri, 10 Mar 2017 19:43:27 +0100, Peter Seiderer wrote:
> On Wed, 8 Mar 2017 20:35:48 -0500, Danomi Manchego <danomimanchego123@gmail.com> wrote:
>
> > Currently, qt.mk installs DejaVu/Vera TrueType fonts if freetype
> > support is available, either from Qt or from the system freetype.
> > However, there are lots of fonts that can be used with Qt, both
> > within Qt (the prerendered fonts) and outside of Qt (in buildroot's
> > font area). So it seems appropriate to expose a switch to enable
> > the installation of the TrueType fonts, conditioned on freetype
> > availability. At least, it provides a similar level of selectability
> > as already exists with the prerendered fonts (micro, fixed, helvetica,
> > etc.), and in some cases may solve problems where setting fonts
> > by family and attribute is complicated by DejaVu competing with
> > fonts that were actually selected in the buildroot menu.
>
> Very detailed explanation for your reasoning, maybe stuff for a
> cover-letter?
I really disagree with this. The contents of cover letters disappear
in the dark caves of the mailing list archives, while commit logs can
very easily be found when looking at the history of the changes on a
package. So I very, very much prefer to have detailed commit logs
rather than everything in the cover letter and very terse commit logs.
I've seen the v2 of Danomi, and now I'm like "why do we want this?".
> Subject: qt: add truetype font installation option
>
> Make truetype font installation optional.
>
> is detailed enough?
No, it's not :)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-14 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 1:35 [Buildroot] [PATCH 1/1] qt: add enable for truetype font installation Danomi Manchego
2017-03-10 18:43 ` Peter Seiderer
2017-03-14 21:58 ` Thomas Petazzoni [this message]
2017-03-14 22:30 ` Danomi Manchego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314225824.04ed09ed@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox