From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] acl: make sure build picks up TARGET_CFLAGS
Date: Sat, 18 Mar 2017 14:12:14 +0100 [thread overview]
Message-ID: <20170318141214.28255e8a@free-electrons.com> (raw)
In-Reply-To: <20170317160616.20570-1-arnout@mind.be>
Hello,
On Fri, 17 Mar 2017 17:06:14 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> The acl build system doesn't use automake, therefore it is broken. It
> doesn't use the CFLAGS passed by configure. Work around this by passing
> CFLAGS in the environment. The makefiles append to CFLAGS, so this
> works.
>
> This issue hasn't led to build failures, but it is visible e.g. when
> stack protector is enabled: the stack protector options are not applied
> to acl. Also debug and optimisation options aren't applied.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> v2: new patch
> ---
> package/acl/acl.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Series applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-03-18 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 16:06 [Buildroot] [PATCH v2 1/3] acl: make sure build picks up TARGET_CFLAGS Arnout Vandecappelle
2017-03-17 16:06 ` [Buildroot] [PATCH v2 2/3] acl: add host variant Arnout Vandecappelle
2017-03-17 16:06 ` [Buildroot] [PATCH v2 3/3] fakeroot: depend on acl Arnout Vandecappelle
2017-03-17 22:17 ` [Buildroot] [PATCH v2 1/3] acl: make sure build picks up TARGET_CFLAGS Andreas Naumann
2017-03-17 22:20 ` Arnout Vandecappelle
2017-03-20 7:54 ` Andreas Naumann
2017-03-20 21:53 ` Arnout Vandecappelle
2017-03-18 13:12 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170318141214.28255e8a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox