From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/3] Add LINUX_DIR to EXTRA_ENV for use in post-build scripts
Date: Sat, 18 Mar 2017 14:23:31 +0100 [thread overview]
Message-ID: <20170318142331.061e2cda@free-electrons.com> (raw)
In-Reply-To: <b7ac0faf-3b85-2439-1386-e181257c2d29@mind.be>
Hello,
On Fri, 17 Mar 2017 23:39:46 +0100, Arnout Vandecappelle wrote:
> On 16-03-17 12:43, Abhimanyu V wrote:
> > From: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com>
> >
> > To build fitImage in post-build scripts, we need compressed
> > kernel binary which is intermediate target, hence doesnt get
> > copied to output/images folder.
> >
> > Signed-off-by: Abhimanyu Vishwakarma <Abhimanyu.Vishwakarma@imgtec.com>
> > Reviewed-by: Rahul Bedarkar <Rahul.Bedarkar@imgtec.com>
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
I am not sure about this one. Why would we pass in the environment
specifically LINUX_DIR, and not the <pkg>_DIR of the other ~2000
packages we have in Buildroot ?
What about instead using BR2_LINUX_KERNEL_VMLINUX_BIN, to get
vmlinux.bin copied to output/images, and then compress it in the
post-build script ?
Or alternatively, if there is a vmlinux.bin.gz target, add support for
it in our linux package?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-18 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 11:43 [Buildroot] [PATCH v4 1/3] uccp420wlan: new package Abhimanyu V
2017-03-16 11:43 ` [Buildroot] [PATCH v4 2/3] Add LINUX_DIR to EXTRA_ENV for use in post-build scripts Abhimanyu V
2017-03-17 22:39 ` Arnout Vandecappelle
2017-03-18 13:23 ` Thomas Petazzoni [this message]
2017-03-18 13:59 ` Arnout Vandecappelle
2017-03-18 14:31 ` Thomas Petazzoni
2017-03-20 7:13 ` Abhimanyu V
2017-03-20 7:08 ` Abhimanyu V
2017-03-16 11:43 ` [Buildroot] [PATCH v4 3/3] Add defconfig for MIPS Creator ci40 Abhimanyu V
2017-03-17 22:36 ` [Buildroot] [PATCH v4 1/3] uccp420wlan: new package Arnout Vandecappelle
2017-03-18 14:34 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170318142331.061e2cda@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox