Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] mono: remove copy of host etc files on install
Date: Sat, 18 Mar 2017 15:39:23 +0100	[thread overview]
Message-ID: <20170318153923.56903d45@free-electrons.com> (raw)
In-Reply-To: <20170315022458.14160-1-dustin.r.johnson@gmail.com>

Hello,

Angelo, could you comment on this patch touching the Mono package?

Copying $(HOST_DIR)/etc/mono to $(TARGET_DIR)/etc has been there since
you contributed the package, but apparently causes some issues. It
would be nice if you could have a look at the patch proposed by Dustin.

Thanks a lot!

Thomas

On Tue, 14 Mar 2017 22:24:58 -0400, Dustin Johnson wrote:
> When the mono package is installed, the autotools installer installs
> the /etc/mono files to the target. A post_install hook then copies
> over the mono libraries to the target as well as the host /etc/mono
> files which overrides the target files. The target specific mono
> configuration file (/etc/mono/config) is overridden with the host
> settings. This causes mono on the target to be unable to locate target
> specific .so files as it overrides the changes enacted by the patches
> for the package.
> 
> Signed-off-by: Dustin Johnson <dustin.r.johnson@gmail.com>
> ---
>  package/mono/mono.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/mono/mono.mk b/package/mono/mono.mk
> index 20b920568..4996b7c60 100644
> --- a/package/mono/mono.mk
> +++ b/package/mono/mono.mk
> @@ -31,7 +31,6 @@ MONO_CONF_OPTS = --disable-gtk-doc \
>  define MONO_INSTALL_LIBS
>  	rsync -av --exclude=*.so --exclude=*.mdb \
>  		$(HOST_DIR)/usr/lib/mono $(TARGET_DIR)/usr/lib/
> -	rsync -av $(HOST_DIR)/etc/mono $(TARGET_DIR)/etc
>  endef
>  
>  MONO_POST_INSTALL_TARGET_HOOKS += MONO_INSTALL_LIBS



-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-03-18 14:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  2:24 [Buildroot] [PATCH 1/1] mono: remove copy of host etc files on install Dustin Johnson
2017-03-18 14:39 ` Thomas Petazzoni [this message]
2017-03-19 16:17   ` Dusty
2017-04-06 17:05     ` Angelo Compagnucci
2017-04-06 17:08     ` Angelo Compagnucci
2017-04-08  3:04       ` Dustin Johnson
2017-05-13 13:27       ` Thomas Petazzoni
2017-05-22 14:53         ` Angelo Compagnucci
2017-05-22 14:52 ` Angelo Compagnucci
2017-06-01 14:15   ` Peter Korsgaard
2017-05-23 14:29 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170318153923.56903d45@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox