[Buildroot] [PATCH v2 2/2] python3: Bump version to 3.6.0

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Tue, 14 Mar 2017 16:42:28 -0700, Andrey Smirnov wrote:
> python3: Bump version to 3.6.0

Thanks for this new version, with updated explanations. It's almost
ready, but I still have a few comments.


> +define PKG_PYTHON_SYSCONFIGDATA_NAME
> +$(shell basename $(shell find $(TARGET_DIR)/ -name "_sysconfigdata_m_linux_*.pyc" | head -n 1) .pyc)
> +endef

Could you replace this with:

+PKG_PYTHON_SYSCONFIGDATA_NAME = \
+       $(basename $(notdir $(wildcard $(STAGING_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/_sysconfigdata_*.py)))

It does the same, but using make code.

To be honest, I find it really annoying that we have to do this to find
the name of the sysconfigdata package. I've thought about the following:

 - Have the Python build system output somewhere the name of the
   sysconfigdata module that has been generated.

 - Compute the name of the sysconfigdata module: it's always going to be:

    sysconfigdata_m_linux_<output of gcc -dumpmachine>

But well, your solution is as simple, so let's go for it.

> -Subject: [PATCH] setup.py: do not add invalid header locations
> +Subject: [PATCH 01/31] setup.py: do not add invalid header locations

Please generate patches with "git format-patch -N" to get rid of the
numbering, i.e to have [PATCH] instead of [PATCH 01/31].


> --- a/package/python3/0003-Make-the-build-of-pyc-files-conditional.patch
> +++ b/package/python3/0002-Make-the-build-of-pyc-files-conditional.patch
> @@ -1,22 +1,24 @@
> -From 5df8e9556e8026dd19cf932fa8f2b726f56182d1 Mon Sep 17 00:00:00 2001
> -From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> -Date: Wed, 23 Dec 2015 11:29:35 +0100
> -Subject: [PATCH] Make the build of pyc files conditional
> +From a3aedafc04a81c5a6406c60e82d072377fee0cd1 Mon Sep 17 00:00:00 2001
> +From: Andrey Smirnov <andrew.smirnov@gmail.com>

Why are all patches you have changed now re-assigned with your From?
You should preserve the authorship of the original author.

>  # Provided to other packages
> -PYTHON3_PATH = $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/sysconfigdata/:$(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/site-packages/
> +PYTHON3_PATH = $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/:$(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/site-packages/

Why do we now need
$(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/ ?

Could you fix the above issues and submit a new version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com