Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 16/16] pkg-download: enable hash check for git downloads
Date: Tue, 21 Mar 2017 01:07:12 +0100	[thread overview]
Message-ID: <20170321000712.26500-17-arnout@mind.be> (raw)
In-Reply-To: <20170321000712.26500-1-arnout@mind.be>

For a while already, our git downloaded tarballs are reproducible, so
we can actually check the hash for them.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Tested 'make pkg-source' for all git-downloaded packages (with and
without hash files).
---
 package/pkg-download.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index cfc550e77b..fbbc2d7391 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -77,6 +77,7 @@ define DOWNLOAD_GIT
 	$(EXTRA_ENV) $(DL_WRAPPER) -b git \
 		-o $(DL_DIR)/$($(PKG)_SOURCE) \
 		$(if $($(PKG)_GIT_SUBMODULES),-r) \
+		-H $(PKGDIR)/$($(PKG)_RAWNAME).hash \
 		$(QUIET) \
 		-- \
 		$($(PKG)_SITE) \
@@ -225,7 +226,7 @@ define SOURCE_CHECK
 endef
 
 define DOWNLOAD_INNER
-	$(Q)$(if $(filter bzr cvs git hg svn,$($(PKG)_SITE_METHOD)),export BR_NO_CHECK_HASH_FOR=$(2);) \
+	$(Q)$(if $(filter bzr cvs hg svn,$($(PKG)_SITE_METHOD)),export BR_NO_CHECK_HASH_FOR=$(2);) \
 	if test -n "$(call qstrip,$(BR2_PRIMARY_SITE))" ; then \
 		case "$(call geturischeme,$(BR2_PRIMARY_SITE))" in \
 			file) $(call $(3)_LOCALFILES,$(BR2_PRIMARY_SITE)/$(2),$(2)) && exit ;; \
-- 
2.11.0

  parent reply	other threads:[~2017-03-21  0:07 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  0:06 [Buildroot] [PATCH 00/16] Enable hash checking for git downloads Arnout Vandecappelle
2017-03-21  0:06 ` [Buildroot] [PATCH 01/16] download/git: create GNU format tar files Arnout Vandecappelle
2017-03-21 22:16   ` Thomas Petazzoni
2017-03-31  6:44   ` Peter Korsgaard
2017-03-21  0:06 ` [Buildroot] [PATCH 02/16] aer-inject: remove redundant _SITE_METHOD Arnout Vandecappelle
2017-03-21  0:06 ` [Buildroot] [PATCH 03/16] fmc: correct hash file Arnout Vandecappelle
2017-03-21 15:17   ` Matthew Weber
2017-03-31  6:45   ` Peter Korsgaard
2017-03-21  0:07 ` [Buildroot] [PATCH 04/16] linux-firmware: correct hash Arnout Vandecappelle
2017-03-31  6:52   ` Peter Korsgaard
2017-03-21  0:07 ` [Buildroot] [PATCH 05/16] squashfs: " Arnout Vandecappelle
2017-03-31  6:53   ` Peter Korsgaard
2017-03-21  0:07 ` [Buildroot] [PATCH 06/16] ubus: add hash Arnout Vandecappelle
2017-03-21  9:47   ` Thomas Petazzoni
2017-03-21  9:54     ` Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 07/16] uhttpd: " Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 08/16] vboot-utils: " Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 09/16] linux: exclude from hash check except for latest version Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 10/16] linux-headers: rework hash exclusion Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 11/16] uboot: exclude from hash check except for latest version Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 12/16] barebox: " Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 13/16] at91bootstrap3: exclude from hash when downloading from git Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 14/16] mxs-bootlets: " Arnout Vandecappelle
2017-03-21  0:07 ` [Buildroot] [PATCH 15/16] arm-trusted-firmware: " Arnout Vandecappelle
2017-03-21  0:07 ` Arnout Vandecappelle [this message]
2017-03-21 12:19 ` [Buildroot] [PATCH 00/16] Enable hash checking for git downloads Ricardo Martincoski
2017-03-21 21:39   ` Arnout Vandecappelle
2017-03-21 22:18 ` Thomas Petazzoni
2017-06-11 12:37 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321000712.26500-17-arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox