From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/script/check-bin-arch: ignore /usr/share
Date: Tue, 21 Mar 2017 22:03:25 +0100 [thread overview]
Message-ID: <20170321210324.GC3735@free.fr> (raw)
In-Reply-To: <1490128516-31437-1-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2017-03-21 21:35 +0100, Thomas Petazzoni spake thusly:
> /usr/share normally should not contain binaries executable for the
> target platform. However, it might contain ELF binaries for other
> platforms, such as firmware files installed by Qemu or
> pru-software-support.
>
> Instead of special-casing each package, let's simply ignore /usr/share.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/6f3fea9f6adaef1573fbb0dd6903b5d99e470610/
> (pru-software-support)
>
> http://autobuild.buildroot.net/results/fe8892bc22a03299fc41e30bfea5e42166838f88/
> (qemu)
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> support/scripts/check-bin-arch | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/support/scripts/check-bin-arch b/support/scripts/check-bin-arch
> index 2c619ad..be2f371 100755
> --- a/support/scripts/check-bin-arch
> +++ b/support/scripts/check-bin-arch
> @@ -27,6 +27,13 @@ for f in ${pkg_files} ; do
> continue
> fi
>
> + # Skip files in /usr/share, several packages (qemu,
> + # pru-software-support) legitimately install ELF binaries that
> + # are not for the target architecture
> + if [[ "${f}" =~ ^\./usr/share/.* ]]; then
> + continue
> + fi
> +
> # Get architecture using readelf. We pipe through 'head -1' so
> # that when the file is a static library (.a), we only take
> # into account the architecture of the first object file.
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-03-21 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 20:35 [Buildroot] [PATCH] support/script/check-bin-arch: ignore /usr/share Thomas Petazzoni
2017-03-21 21:03 ` Yann E. MORIN [this message]
2017-03-21 21:15 ` Peter Korsgaard
2017-03-22 8:24 ` Peter Korsgaard
2017-03-22 13:06 ` Thomas Petazzoni
2017-03-22 21:43 ` Peter Korsgaard
2017-03-22 22:04 ` Thomas Petazzoni
2017-03-22 23:03 ` Arnout Vandecappelle
2017-03-23 8:16 ` Thomas Petazzoni
2017-03-28 11:50 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321210324.GC3735@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox