[Buildroot] [PATCH v3 2/5] support/testing: add core tests

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Hello,

On Wed, 22 Mar 2017 09:17:59 +0100, Thomas De Schampheleire wrote:

> Two minor comments:
> 
> I think it would be cleaner to move support files for tests, like the
> post-build.sh and post-image.sh and rootfs-overlays, to a subdirectory
> instead of in the same location as the tests.

Can you suggest a name for this subdirectory ? :-)

> Also, I would argue that the rootfs-overlays do not need to be real
> files in git but can be generated on the fly during the test.

I tried to do that, but:

 1. It complicates quite a bit the test scenario.

 2. There are plenty of other test cases where we will really need some
    data that cannot be generated: a set of patches to test if patches
    on packages are properly applied, a set of dummy BR2_EXTERNAL
    trees, etc. So we will anyway have some "supporting" artifacts in
    the tree, and therefore I thought it wasn't worth the effort making
    this test more complicated.

Yann did the exact same comment while reviewing the previous version,
so I tried generating the files automatically, and went through this
reasoning before giving up and keeping things as they are.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com