From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2,1/2] libmediaart: new package
Date: Fri, 24 Mar 2017 21:57:27 +0100 [thread overview]
Message-ID: <20170324215727.3d17fc1b@free-electrons.com> (raw)
In-Reply-To: <1490387931-113759-1-git-send-email-fontaine.fabrice@gmail.com>
Hello,
On Fri, 24 Mar 2017 21:38:50 +0100, Fabrice Fontaine wrote:
> +else ifeq ($(BR2_PACKAGE_MEDIAART_BACKEND_QT),y)
> +# qt5 needs c++11 (since qt-5.7)
> +ifeq ($(BR2_QT5_VERSION_LATEST),y)
Should be:
BR2_PACKAGE_QT5_VERSION_LATEST
It has been changed in commit
https://git.buildroot.org/buildroot/commit/package/qt5/Config.in?id=49a33d3a229571e22ab783cbb1e5cace06ad7b99.
> +LIBMEDIAART_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11"
> +endif
> +LIBMEDIAART_DEPENDENCIES += \
> + $(if $(BR2_PACKAGE_QT),qt) \
> + $(if $(BR2_PACKAGE_QT5),qt5base)
> +LIBMEDIAART_CONF_OPTS += \
> + --disable-gdkpixbuf \
> + --enable-qt
> +else ifeq ($(BR2_PACKAGE_MEDIAART_BACKEND_NONE),y)
> +LIBMEDIAART_CONF_OPTS += \
> + --disable-gdkpixbuf \
> + --disable-qt
> +endif
Are the backends really mutually exclusive?
Why don't we simply do:
ifeq ($(BR2_PACKAGE_QT)$(BR2_PACKAGE_QT5),y)
... enable QT backend ...
else
... disable QT backend
endif
ifeq ($(BR2_PACKAGE_GDK_PIXBUF),y)
... enable GDK pixbuf backend ...
else
... disable GDK pixbuf backend ...
endif
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-24 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 20:38 [Buildroot] [PATCH v2,1/2] libmediaart: new package Fabrice Fontaine
2017-03-24 20:38 ` [Buildroot] [PATCH v2,2/2] rygel: " Fabrice Fontaine
2017-07-03 22:56 ` Romain Naour
2017-10-22 12:45 ` Thomas Petazzoni
2017-03-24 20:57 ` Thomas Petazzoni [this message]
2017-03-25 10:10 ` [Buildroot] [PATCH v2,1/2] libmediaart: " Fabrice Fontaine
2017-03-25 13:06 ` Thomas Petazzoni
2017-03-29 21:51 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324215727.3d17fc1b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox