From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 26 Mar 2017 23:44:15 +0200 Subject: [Buildroot] [PATCH] core/br2-external: properly report unexpected errors In-Reply-To: <1485600092-963-1-git-send-email-yann.morin.1998@free.fr> References: <1485600092-963-1-git-send-email-yann.morin.1998@free.fr> Message-ID: <20170326234415.2192a445@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sat, 28 Jan 2017 11:41:32 +0100, Yann E. MORIN wrote: > Unextected error in the br2-external script are properly caught, but > they are not reported properly, and we end up in either of two > situations: > > - the .br2-external.mk file is not generated, in which case make will > try to find a rule to generate it (because the 'include' directive > tries to generate missing files); > > - the .br-external.mk file is generated but does not contain the error > variable, and thus the build might not get interrupted. > > We fix that by using a trap on the pseudo ERR signal, to emit the error > variable on unexpected errors. > > Signed-off-by: "Yann E. MORIN" > --- > support/scripts/br2-external | 3 +++ > 1 file changed, 3 insertions(+) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com