From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] package/mesa3d: explicitely disable asm
Date: Wed, 29 Mar 2017 23:35:28 +0200 [thread overview]
Message-ID: <20170329233528.1eb13394@free-electrons.com> (raw)
In-Reply-To: <49fce2a1-49a7-317c-486f-b3b6c37604a9@gmail.com>
Hello,
On Wed, 29 Mar 2017 23:28:56 +0200, Romain Naour wrote:
> Le 29/03/2017 ? 06:41, Bernd Kuhls a ?crit :
> > Am Sun, 26 Mar 2017 18:28:52 +0200 schrieb Romain Naour:
> >
> >> assembly are enabled by default on supported plaforms even while
> >> crosscompiling if host == target:
> >>
> >> checking whether to enable assembly... yes, x86_64
> >>
> >> It was also disabled in the mesa package in Fedora since 7.6 [1].
> >>
> >> [1] http://pkgs.fedoraproject.org/cgit/rpms/mesa.git/commit/?id=629c8726
> >
> > Hi,
> >
> > I am unsure about this patch, why shouldn't we use asm code when
> > crosscompiling for host == target CPU?
>
> To be honest I don't really have an issue with assembly being enabled for my use
> case. But there is an issue when you want a reproducible build with the same
> defconfig build on a x86 and x86_64 host.
For which architectures is the assembly code available? We should
forcefully enable it for those architectures.
I agree with Romain that we shouldn't depend on something that looks at
the architecture of the host machine to decide if a feature for the
target should be enabled or not.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-03-29 21:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 16:28 [Buildroot] [PATCH 1/5] package/mesa3d: allow to enable OpenGL texture float support Romain Naour
2017-03-26 16:28 ` [Buildroot] [PATCH 2/5] package/mesa3d: add libvdpau optional dependency Romain Naour
2017-04-01 13:56 ` Thomas Petazzoni
2017-03-26 16:28 ` [Buildroot] [PATCH 3/5] package/meda3d: add xlib_libXvMC " Romain Naour
2017-04-01 13:57 ` Thomas Petazzoni
2017-03-26 16:28 ` [Buildroot] [PATCH 4/5] package/mesa3d: explicitely disable asm Romain Naour
2017-03-29 4:41 ` Bernd Kuhls
2017-03-29 21:28 ` Romain Naour
2017-03-29 21:35 ` Thomas Petazzoni [this message]
2017-03-29 21:55 ` Romain Naour
2017-04-01 13:59 ` Thomas Petazzoni
2017-03-26 16:28 ` [Buildroot] [PATCH 5/5] package/mesa3d: enable gallium extra hud Romain Naour
2017-03-28 17:49 ` [Buildroot] [PATCH 1/5] package/mesa3d: allow to enable OpenGL texture float support Bernd Kuhls
2017-03-28 20:38 ` Romain Naour
2017-03-29 4:41 ` Bernd Kuhls
2017-03-29 21:46 ` Romain Naour
2017-04-01 13:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329233528.1eb13394@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox