Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pacakge/dieharder: fix autoreconf
Date: Sat, 1 Apr 2017 22:06:22 +0200	[thread overview]
Message-ID: <20170401220622.02152a5c@free-electrons.com> (raw)
In-Reply-To: <20170401190909.27403-1-yann.morin.1998@free.fr>

Hello,

On Sat,  1 Apr 2017 21:09:09 +0200, Yann E. MORIN wrote:
> When dieharder was committed, Thomas reoved the hook to cleanup the m4
> files, on the reason that autoreconf would rereate the broken symlinks
> (and because the hook was too complex).
> 
> It turns out the hook was needed: autoreconf does not recreate the files
> (at least not in some autobuilders nor on my machine).
> 
> Reinstate a simpler hook.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/a92/a92e9a74b0966f8f0bc4080f918d5ddf4c1ec0ce/
>     http://autobuild.buildroot.org/results/a4f/a4f6647f69ad89ff1ffe5f1331281fb7a57ade4e/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Julien Viard de Galbert <julien@vdg.name>
> ---
>  package/dieharder/dieharder.mk | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

Applied to master after fixing a few typoes, and adjusting the commit
log/comments with the fact that it was indeed working for me because I
had libtool installed. So the problem is not just the fact that the
symlinks are not overwritten by autoreconf, but that they are not
overwritten if they are broken symbolic links in the first place.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2017-04-01 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 19:09 [Buildroot] [PATCH] pacakge/dieharder: fix autoreconf Yann E. MORIN
2017-04-01 20:06 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170401220622.02152a5c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox