From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] uhttpd: fix TCP_FASTOPEN related compile error
Date: Mon, 3 Apr 2017 21:19:54 +0200 [thread overview]
Message-ID: <20170403211954.34d4ab7f@free-electrons.com> (raw)
In-Reply-To: <20170403172908.10642-1-ps.report@gmx.net>
Hello,
On Mon, 3 Apr 2017 19:29:08 +0200, Peter Seiderer wrote:
> Fixes [1]:
>
> .../uhttpd-a8bf9c00842224edb394e79909053f7628ee6a82/listen.c: In function 'uh_setup_listeners':
> .../uhttpd-a8bf9c00842224edb394e79909053f7628ee6a82/listen.c:120:30: error: 'TCP_FASTOPEN' undeclared (first use in this function)
>
> [1] http://autobuild.buildroot.net/results/56e/56e0727ccd1255b05e03d1b79dc238bd88701230
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
> - use conditional define for TCP_FASTOPEN (Baruch Siach, Thomas Petazzoni)
> - fix subject typo (Thomas Petazzoni)
> ---
> ...02-Fix-TCP_FASTOPEN-related-compile-error.patch | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 package/uhttpd/0002-Fix-TCP_FASTOPEN-related-compile-error.patch
Applied to master, thanks. Baruch: I read your comment about whether
the #ifndef TCP_FASTOPEN...#endif should be inside a #ifdef
linux...#endif condition or not. I believe there are arguments both
ways, so I'm not sure it's really worth to bikeshed on this too much.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2017-04-03 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 17:29 [Buildroot] [PATCH v2] uhttpd: fix TCP_FASTOPEN related compile error Peter Seiderer
2017-04-03 17:36 ` Baruch Siach
2017-04-03 17:48 ` Peter Seiderer
2017-04-03 18:16 ` Baruch Siach
2017-04-03 19:19 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403211954.34d4ab7f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox