From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] odroid-mali: fix broken headers.
Date: Tue, 4 Apr 2017 22:02:54 +0200 [thread overview]
Message-ID: <20170404220254.0ae579a7@free-electrons.com> (raw)
In-Reply-To: <20170325123918.19055-1-daggs@gmx.com>
Hello,
On Sat, 25 Mar 2017 15:39:17 +0300, Dagg Stompler wrote:
> -ODROID_MALI_VERSION = 46fe49f37e3506c6205ad8c50980eca9bfff11e3
> +ODROID_MALI_VERSION = 4f8a541693fee5fdcaa162a7fd8922861a4ba0a9
> ODROID_MALI_SITE = $(call github,mdrjr,c2_mali,$(ODROID_MALI_VERSION))
> ODROID_MALI_LICENSE = Hardkernel EULA
> ODROID_MALI_LICENSE_FILES = README.md
> @@ -44,4 +44,11 @@ define ODROID_MALI_INSTALL_TARGET_CMDS
> $(call ODROID_MALI_INSTALL_LIBS,$(TARGET_DIR))
> endef
>
> +ifneq ($(BR2_PACKAGE_XLIB_LIBX11),y)
Rather than this condition, I've used the existing
BR2_PACKAGE_ODROID_MALI_X11 condition in odroid-mali.mk.
> +define ODROID_MALI_FIX_EGL_PC
> + $(SED) "s/: -I/: -DMESA_EGL_NO_X11_HEADERS -I/" $(STAGING_DIR)/usr/lib/pkgconfig/egl.pc
> +endef
> +ODROID_MALI_POST_INSTALL_TARGET_HOOKS += ODROID_MALI_FIX_EGL_PC
Using a post-install *target* hook to tweak things in the staging
directory is not very clean. Instead, I've changed your patch to call
ODROID_MALI_FIX_EGL_PC from ODROID_MALI_INSTALL_STAGING_CMDS.
Applied with those fixes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-04-04 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 12:39 [Buildroot] [PATCH v2 1/2] odroid-mali: fix broken headers Dagg Stompler
2017-03-25 12:39 ` [Buildroot] [PATCH v2 2/2] Revert "odroid-mali: mark package as BROKEN" Dagg Stompler
2017-04-04 20:02 ` Thomas Petazzoni
2017-04-04 20:02 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404220254.0ae579a7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox