From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 02/39] package/libdvdread: add Kodi-specific patches
Date: Thu, 6 Apr 2017 22:38:31 +0200 [thread overview]
Message-ID: <20170406223831.648c10df@free-electrons.com> (raw)
In-Reply-To: <20170323172900.25458-3-bernd.kuhls@t-online.de>
Hello,
On Thu, 23 Mar 2017 18:28:23 +0100, Bernd Kuhls wrote:
> +# enable Kodi-specific code
> +ifeq ($(BR2_PACKAGE_KODI),y)
> +LIBDVDREAD_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -D_XBMC"
> +endif
This really feels clunky (ditto in patch 03/39). Why does the Kodi
related code needs to be conditional?
What if libdvdread is used in the same system for Kodi and for
something else?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-06 20:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:28 [Buildroot] [PATCH v4 00/39] kodi: bump to version 17.1-Krypton Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 01/39] package/libdvdcss: add Kodi-specific patches Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 02/39] package/libdvdread: " Bernd Kuhls
2017-04-06 20:38 ` Thomas Petazzoni [this message]
2017-04-09 14:38 ` Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 03/39] package/libdvdnav: " Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 04/39] package/libplatform: bump version to 2.1.0 Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 05/39] package/kodi-platform: bump version Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 06/39] package/libcec: bump version to 4.0.2 Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 07/39] package/xmlstarlet: add host variant Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 08/39] package/kodi-jsonschemabuilder: new host package Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 09/39] package/kodi-texturepacker: " Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 10/39] package/kodi: bump to version 17.1-Krypton Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 11/39] package/kodi: add patch to disable online check Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 12/39] package/kodi-inputstream-rtmp: new package Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 13/39] package/kodi: move rtmp support to new addon kodi-inputstream-rtmp Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 14/39] package/kodi: add aarch64 support Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 15/39] package/kodi: add powerpc64 support Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 16/39] package/kodi: add mips64el support Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 17/39] package/kodi: add optional support for bluez5 Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 18/39] package/kodi: libxslt is an optional package Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 19/39] package/kodi: add optional support for pulseaudio Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 20/39] package/kodi: add optional support for event clients Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 21/39] package/kodi: add optional support for lcms2 Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 22/39] package/libsquish: remove deprecated package Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 23/39] package/kodi-pvr-*: mass version bump Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 24/39] package/kodi-pvr-mythtv: bump version to 4.15.0 Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 25/39] package/kodi-pvr-nextpvr: bump version to 2.4.11 Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 26/39] package/kodi-pvr-mediaportal-tvserver: needs locale support Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 27/39] package/kodi-adsp-basic: bump version Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 28/39] package/kodi-adsp-freesurround: " Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 29/39] package/kodi-audioencoder-*: mass version bump Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 30/39] package/kodi-audiodecoder-*: " Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 31/39] package/kodi-audiodecoder-timidity: bump version Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 32/39] package/kodi-screensaver-*: mass version bump Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 33/39] package/kodi-screensaver-rsxs: bump version Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 34/39] package/kodi-visualisation-*: mass version bump Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 35/39] package/kodi-visualisation-waveforhue: bump version Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 36/39] package/kodi-visualisation-shadertoy: " Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 37/39] package/kodi-inputstream-adaptive: new package Bernd Kuhls
2017-03-23 17:28 ` [Buildroot] [PATCH v4 38/39] package/kodi-skin-confluence: " Bernd Kuhls
2017-03-23 17:29 ` [Buildroot] [PATCH v4 39/39] package/kodi: add Kconfig options to remove default skins Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406223831.648c10df@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox