Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Waldemar Brodkorb <wbx@openadk.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality
Date: Sun, 9 Apr 2017 06:32:15 +0200	[thread overview]
Message-ID: <20170409043215.GT5361@waldemar-brodkorb.de> (raw)
In-Reply-To: <20170321170614.161e8eec@free-electrons.com>

Hi,
Thomas Petazzoni wrote,

> Hello,
> 
> On Tue, 21 Mar 2017 18:02:36 +0200, Andy Shevchenko wrote:
> 
> > The commit d7c54cb0c0cf ("bluez5_utils: not available with uClibc")
> > disables bluez5_utils (most of them) to be built with uClibc. Looking to
> > the development of BlueZ user space support that commit basically makes
> > the bluez5_utils package somewhat piece of junk.
> 
> Not sure I understand what you mean here.
> 
> > Since bluez5_utils 5.44
> > deprecates all previously used tools and focuses on btmgmt and
> > bluetoothctl we need to restore status quo.
> 
> Same here, I don't understand.
> 
> > diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config
> > index 528bce965..91082975e 100644
> > --- a/package/uclibc/uClibc-ng.config
> > +++ b/package/uclibc/uClibc-ng.config
> > @@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
> >  UCLIBC_HAS_PRINTF_M_SPEC=y
> >  # UCLIBC_HAS_REGEX_OLD is not set
> >  # UCLIBC_HAS_FNMATCH_OLD is not set
> > +UCLIBC_HAS_WORDEXP=y
> >  UCLIBC_HAS_NFTW=y
> >  UCLIBC_HAS_FTW=y
> >  UCLIBC_HAS_GNU_GLOB=y
> 
> Could you comment on the size impact of enabling this option? I.e the
> size of uClibc without/with this option enabled, for example on ARM?

For mips64:
diff --git a/package/uclibc/uClibc-ng.config
b/package/uclibc/uClibc-ng.config
index 528bce9..9108297 100644
--- a/package/uclibc/uClibc-ng.config
+++ b/package/uclibc/uClibc-ng.config
@@ -32,6 +32,7 @@ UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y
 UCLIBC_HAS_PRINTF_M_SPEC=y
 # UCLIBC_HAS_REGEX_OLD is not set
 # UCLIBC_HAS_FNMATCH_OLD is not set
+UCLIBC_HAS_WORDEXP=y
 UCLIBC_HAS_NFTW=y
 UCLIBC_HAS_FTW=y
 UCLIBC_HAS_GNU_GLOB=y
wbx at helium:~/buildroot$ ls -la t1/lib/libu*
-rwxr-xr-x 1 wbx wbx 655320 Apr  8 22:00 t1/lib/libuClibc-1.0.23.so
wbx at helium:~/buildroot$ ls -la t2/lib/libu*
-rwxr-xr-x 1 wbx wbx 672280 Apr  8 23:08 t2/lib/libuClibc-1.0.23.so
wbx at helium:~/buildroot$ bc
bc 1.06.95
Copyright 1991-1994, 1997, 1998, 2000, 2004, 2006 Free Software
Foundation, Inc.
This is free software with ABSOLUTELY NO WARRANTY.
For details type `warranty'. 
672280-655320
16960

16960 Bytes. Can we enable it by default?

best regards
 Waldemar

  parent reply	other threads:[~2017-04-09  4:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 16:02 [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Andy Shevchenko
2017-03-21 16:02 ` [Buildroot] [PATCH v2] package/uclibc: Enable wordexp functionality Andy Shevchenko
2017-03-21 16:06   ` Thomas Petazzoni
2017-03-21 16:11     ` Andy Shevchenko
2017-03-21 16:17       ` Thomas Petazzoni
2017-03-21 16:23         ` Andy Shevchenko
2017-03-21 16:28       ` Baruch Siach
2017-04-09  4:32     ` Waldemar Brodkorb [this message]
2017-04-09  7:42       ` Thomas Petazzoni
2017-03-21 19:53   ` Waldemar Brodkorb
2017-04-16 14:29   ` Waldemar Brodkorb
2017-04-29 12:26   ` Thomas Petazzoni
2017-03-21 16:02 ` [Buildroot] [PATCH v2] Revert "bluez5_utils: not available with uClibc" Andy Shevchenko
2017-03-21 17:01 ` [Buildroot] [PATCH v2] package/bluez5_utils: Allow user to enable disabled plugins Peter Korsgaard
2017-03-21 17:06   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170409043215.GT5361@waldemar-brodkorb.de \
    --to=wbx@openadk.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox