Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] libselinux: allow compiling python wrapper module for target
Date: Sun, 9 Apr 2017 15:44:22 +0200	[thread overview]
Message-ID: <20170409154422.16c86a64@free-electrons.com> (raw)
In-Reply-To: <20170202224505.22882-3-Adamduskett@outlook.com>

Hello,

On Thu,  2 Feb 2017 17:45:04 -0500, Adam Duskett wrote:
> libselinux currently does not compile it's python wrapper module
> for the target.  This is needed for audit2allow to function properly.
> 
> This patch allows for the python wrapper to be built.  The current
> makefile will try to install the python wrapper to the host directory
> unless the PYSITEDIR variable is set.  I wrapped the build of the
> python wrapper in a check for AUDIT2ALLOW because of the extra python
> dependency, as I am sure many users don't want to have to install
> python if they don't have to.
> 
> Signed-off-by: Adam Duskett <Adamduskett@outlook.com>
> ---
>  package/libselinux/libselinux.mk | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Applied to master with the following changes:

    [Thomas:
     - Remove useless empty lines, as noted by Matt Weber
     - Move code related to python bindings before builds/install
       commands, since those commands will use variables defined by the
       python bindings logic.
     - Instead of enabling the python bindings when
       BR2_PACKAGE_POLICYCOREUTILS_AUDIT2ALLOW is set, enable the python
       bindings when python is available. We generally try to avoid
       looking at options of other packages to decide what to install.
     - Introduce LIBSELINUX_MAKE_TARGETS and
       LIBSELINUX_MAKE_INSTALL_TARGETS variable, in order to avoid
       duplicate the make/make install commands.
     - As suggested by Matt Weber, remove LIBSELINUX_PYTHONLIBDIR
       definitions, and don't pass PYLIBVER and PYTHONLIBDIR in
    MAKE_OPTS.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2017-04-09 13:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-02 22:45 [Buildroot] [PATCH 1/4] sepolgen: allow compiling for target Adam Duskett
2017-02-02 22:45 ` [Buildroot] [PATCH 2/4] checkpolicy: " Adam Duskett
2017-03-27 17:04   ` Matthew Weber
2017-03-27 19:13     ` Matthew Weber
2017-04-03 13:14       ` Adam Duskett
2017-04-03 13:38         ` Matthew Weber
2017-04-09 13:43   ` Thomas Petazzoni
2017-02-02 22:45 ` [Buildroot] [PATCH 3/4] libselinux: allow compiling python wrapper module " Adam Duskett
2017-03-27 17:21   ` Matthew Weber
2017-03-27 19:19     ` Matthew Weber
2017-04-04  2:09       ` Matthew Weber
2017-04-09 13:44   ` Thomas Petazzoni [this message]
2017-04-11 12:40   ` Thomas Petazzoni
2017-04-12 12:53     ` Matthew Weber
2017-04-12 13:54       ` Matthew Weber
2017-04-12 14:00         ` Matthew Weber
2017-04-12 20:45           ` Matthew Weber
2017-02-02 22:45 ` [Buildroot] [PATCH 4/4] policycoreutils: add option to build audit2allow Adam Duskett
2017-03-27 17:22   ` Matthew Weber
2017-03-27 19:20     ` Matthew Weber
2017-04-09 13:44   ` Thomas Petazzoni
2017-03-27 19:11 ` [Buildroot] [PATCH 1/4] sepolgen: allow compiling for target Matthew Weber
2017-04-09 13:43 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170409154422.16c86a64@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox