From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/pngquant: new package
Date: Sun, 9 Apr 2017 16:05:29 +0200 [thread overview]
Message-ID: <20170409160529.64e61007@free-electrons.com> (raw)
In-Reply-To: <20170408151804.11102-2-bernd.kuhls@t-online.de>
Hello,
On Sat, 8 Apr 2017 17:18:03 +0200, Bernd Kuhls wrote:
> +define HOST_PNGQUANT_CONFIGURE_CMDS
> + (cd $(@D) && \
> + $(HOST_CONFIGURE_OPTS) \
> + ./configure --prefix=/usr \
--prefix=/usr is not correct for host packages, it should be
--prefix=$(HOST_DIR)/usr.
> +define HOST_PNGQUANT_INSTALL_CMDS
> + $(HOST_MAKE_ENV) $(MAKE) PREFIX="$(HOST_DIR)/usr" -C $(@D) install
Then passing PREFIX= here becomes useless.
> +define PNGQUANT_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) PREFIX="$(TARGET_DIR)/usr" -C $(@D) install
And here passing DESTDIR=$(TARGET_DIR) makes more sense, since
--prefix=/usr is passed at configuration time.
I've fixed this, and grouped together the host configure/build/install
commands, and then applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-09 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 15:18 [Buildroot] [PATCH 1/3] package/tvheadend: bump version Bernd Kuhls
2017-04-08 15:18 ` [Buildroot] [PATCH 2/3] package/pngquant: new package Bernd Kuhls
2017-04-09 14:05 ` Thomas Petazzoni [this message]
2017-04-08 15:18 ` [Buildroot] [PATCH 3/3] package/tvheadend: reduce target binary size by using pngquant Bernd Kuhls
2017-04-09 14:06 ` Thomas Petazzoni
2017-04-08 19:44 ` [Buildroot] [PATCH 1/3] package/tvheadend: bump version Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409160529.64e61007@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox