From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/autobuild 4/8] autobuild-run: remove redundant 'make oldconfig'
Date: Sun, 9 Apr 2017 22:51:24 +0200 [thread overview]
Message-ID: <20170409205128.11560-4-arnout@mind.be> (raw)
In-Reply-To: <20170409205128.11560-1-arnout@mind.be>
After running 'make randpackageconfig', and additional 'make oldconfig'
is done. However, this is redundant, since randpackageconfig already
does an olddefconfig.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
scripts/autobuild-run | 6 ------
1 file changed, 6 deletions(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 42276db..1df1ce0 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -586,12 +586,6 @@ def gen_config(**kwargs):
if fixup_config(**kwargs):
break
- ret = subprocess.call(["yes '' 2>/dev/null| make O=%s -C %s oldconfig" % \
- (outputdir, srcdir)], shell=True, stdout=devnull, stderr=devnull)
- if ret != 0:
- log_write(log, "ERROR: cannot oldconfig")
- return -1
-
ret = subprocess.call(["make", "O=%s" % outputdir, "-C", srcdir, "savedefconfig"],
stdout=devnull, stderr=devnull)
if ret != 0:
--
2.11.0
next prev parent reply other threads:[~2017-04-09 20:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-09 20:51 [Buildroot] [PATCH/autobuild 1/8] autobuild-run: fix typo in help text Arnout Vandecappelle
2017-04-09 20:51 ` [Buildroot] [PATCH/autobuild 2/8] autobuild-run: add '-d, --debug' option Arnout Vandecappelle
2017-04-10 8:22 ` Thomas Petazzoni
2017-04-10 8:45 ` Arnout Vandecappelle
2017-04-09 20:51 ` [Buildroot] [PATCH/autobuild 3/8] autobuild-run: use 'olddefconfig' instead of 'oldconfig' Arnout Vandecappelle
2017-04-09 20:51 ` Arnout Vandecappelle [this message]
2017-04-10 8:25 ` [Buildroot] [PATCH/autobuild 4/8] autobuild-run: remove redundant 'make oldconfig' Thomas Petazzoni
2017-04-10 8:46 ` Arnout Vandecappelle
2017-04-12 9:27 ` Thomas Petazzoni
2017-04-09 20:51 ` [Buildroot] [PATCH/autobuild 5/8] autobuild-run: check that toolchain config lines are still present Arnout Vandecappelle
2017-04-10 8:28 ` Thomas Petazzoni
2017-04-10 8:48 ` Arnout Vandecappelle
2017-04-09 20:51 ` [Buildroot] [PATCH/autobuild 6/8] autobuild-run: remove check for glibc Arnout Vandecappelle
2017-04-09 20:51 ` [Buildroot] [PATCH/autobuild 7/8] autobuild-run: simplify, don't make a dict of config Arnout Vandecappelle
2017-04-09 20:51 ` [Buildroot] [PATCH/autobuild 8/8] autobuild-run: use in-tree toolchain configs Arnout Vandecappelle
2017-04-10 8:49 ` Arnout Vandecappelle
2017-04-10 8:50 ` [Buildroot] [PATCH] " Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409205128.11560-4-arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox