From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/autobuild v2 6/7] autobuild-run: simplify, don't make a dict of config
Date: Wed, 12 Apr 2017 22:42:59 +0200 [thread overview]
Message-ID: <20170412224259.2c201c0f@free-electrons.com> (raw)
In-Reply-To: <20170410220003.30421-6-arnout@mind.be>
Hello,
On Tue, 11 Apr 2017 00:00:02 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> - configlines = config["contents"]
> + configlines = config
So, using directly the variable named "config" in the remainder of this
function would be more logical, no?
(Note: as I said, I have already applied the patch, so further
improvements need to be done as follow-up patches)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-12 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 21:59 [Buildroot] [PATCH/autobuild v2 1/7] autobuild-run: fix typo in help text Arnout Vandecappelle
2017-04-10 21:59 ` [Buildroot] [PATCH/autobuild v2 2/7] autobuild-run: add '-d, --debug' option Arnout Vandecappelle
2017-04-10 21:59 ` [Buildroot] [PATCH/autobuild v2 3/7] autobuild-run: use 'olddefconfig' instead of 'oldconfig' Arnout Vandecappelle
2017-04-10 22:00 ` [Buildroot] [PATCH/autobuild v2 4/7] autobuild-run: check that toolchain config lines are still present Arnout Vandecappelle
2017-04-10 22:00 ` [Buildroot] [PATCH/autobuild v2 5/7] autobuild-run: remove check for glibc Arnout Vandecappelle
2017-04-10 22:00 ` [Buildroot] [PATCH/autobuild v2 6/7] autobuild-run: simplify, don't make a dict of config Arnout Vandecappelle
2017-04-12 20:42 ` Thomas Petazzoni [this message]
2017-04-13 20:41 ` Arnout Vandecappelle
2017-04-10 22:00 ` [Buildroot] [PATCH/autobuild v2 7/7] autobuild-run: use in-tree toolchain configs Arnout Vandecappelle
2017-04-12 20:42 ` [Buildroot] [PATCH/autobuild v2 1/7] autobuild-run: fix typo in help text Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412224259.2c201c0f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox